New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make top bar fixed to the top - Closes #1727 #1729

Merged
merged 11 commits into from Feb 5, 2019

Conversation

Projects
3 participants
@osvaldovega
Copy link
Contributor

osvaldovega commented Feb 4, 2019

What issue have I solved?

-- #1727

How have I implemented/fixed it?

Update the css file of the topBar to make the bar be always in the top even if the user scroll down.
Then in the other hand I update the logout function to do not show the dialog message any more and just make the user to be in the logout screen.

How has this been tested?

login into the app.
do click in the Show More button of the Latest Activities or New Feeds and then scroll down.
The TopBar menu should be fixed always in the top.

Then logout the app.
There is no more dialog after logout and the user should be logged out

Review checklist

@osvaldovega osvaldovega self-assigned this Feb 4, 2019

@osvaldovega osvaldovega added this to Pull Requests in Version 1.11.0 via automation Feb 4, 2019

@osvaldovega osvaldovega requested a review from renatomassao Feb 4, 2019

@renatomassao
Copy link
Contributor

renatomassao left a comment

Good Job! 🥇

@Efefefef

This comment has been minimized.

Copy link
Contributor

Efefefef commented Feb 5, 2019

@osvaldovega Pls resolve merge conflict

Efefefef and others added some commits Feb 5, 2019

@osvaldovega osvaldovega changed the base branch from 1.11.0 to development Feb 5, 2019

@osvaldovega osvaldovega changed the base branch from development to 1.11.0 Feb 5, 2019

@osvaldovega

This comment has been minimized.

Copy link
Contributor Author

osvaldovega commented Feb 5, 2019

merge conflicts fixed

@Efefefef
Copy link
Contributor

Efefefef left a comment

👍

@Efefefef Efefefef added ready and removed ☑️ pending QA labels Feb 5, 2019

@osvaldovega osvaldovega merged commit 0847ca2 into 1.11.0 Feb 5, 2019

5 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls Coverage remained the same at 93.756%
Details
security/snyk - package.json (LiskHQ) No new issues
Details

Version 1.11.0 automation moved this from Pull Requests to Merged Pull Requests Feb 5, 2019

@osvaldovega osvaldovega deleted the 1727-make-topBar-fixed-to-the-top branch Feb 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment