New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement On-Boarding module in wallet - Closes #1669 #1734

Merged
merged 9 commits into from Feb 8, 2019

Conversation

Projects
3 participants
@renatomassao
Copy link
Contributor

renatomassao commented Feb 5, 2019

What issue have I solved?

#1669

How have I implemented/fixed it?

Updated Banner component to show a close button if a prop onClose is passed.
Added the banner to the /wallet page, it should show up if the account has no balance, and the user didn't close the on boarding yet, after closing it sets a key closedWalletOnboarding to localStorage.

How has this been tested?

Create a new account and go to /wallet and the banner should appear, after closing the banner even reloading the page should show the banner again.
With an account with balance, the banner should never show up, even without the localStorage key
closedWalletOnboarding set.

Review checklist

@renatomassao renatomassao self-assigned this Feb 5, 2019

@renatomassao renatomassao added this to Pull Requests in Version 1.11.0 via automation Feb 5, 2019

@renatomassao renatomassao changed the title Implement on boarding module in wallet - Closes #1669 Implement On-Boarding module in wallet - Closes #1669 Feb 5, 2019

renatomassao added some commits Feb 5, 2019

Merge branch '1669-implement-on-boarding-module-wallet' of github.com…
…:LiskHQ/lisk-hub into 1669-implement-on-boarding-module-wallet

@renatomassao renatomassao changed the base branch from 1.11.0 to development Feb 7, 2019

@renatomassao renatomassao changed the base branch from development to 1.11.0 Feb 7, 2019

renatomassao added some commits Feb 7, 2019

@renatomassao renatomassao requested a review from slaweet Feb 7, 2019

@slaweet slaweet requested review from Efefefef and osvaldovega and removed request for slaweet and Efefefef Feb 7, 2019

@osvaldovega
Copy link
Contributor

osvaldovega left a comment

I tested and the code looks good

@Efefefef
Copy link
Contributor

Efefefef left a comment

Wording from Jacob:
Add some LSK to your Lisk Hub account now!

You can find the LSK token on all of the worlds top exchanges and send them to your unique Lisk address:

@Efefefef

This comment has been minimized.

Copy link
Contributor

Efefefef commented Feb 8, 2019

Besides that: 👍 And great e2e test 🏅

@renatomassao

This comment has been minimized.

Copy link
Contributor Author

renatomassao commented Feb 8, 2019

@Efefefef Just updated the texts.

@Efefefef Efefefef added ready and removed ☑️ pending QA labels Feb 8, 2019

@renatomassao renatomassao merged commit 48b6147 into 1.11.0 Feb 8, 2019

5 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls Coverage remained the same at 93.522%
Details
security/snyk - package.json (LiskHQ) No new issues
Details

Version 1.11.0 automation moved this from Pull Requests to Merged Pull Requests Feb 8, 2019

@renatomassao renatomassao deleted the 1669-implement-on-boarding-module-wallet branch Feb 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment