New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace old wallet with new wallet - Closes #1705 #1736

Merged
merged 11 commits into from Feb 7, 2019

Conversation

Projects
3 participants
@renatomassao
Copy link
Contributor

renatomassao commented Feb 5, 2019

What issue have I solved?

#1705

How have I implemented/fixed it?

Deleted walletTransactions folder, which had the previous wallet page, didn't delete the transactions file, since the old ones are still being used on some parts of the application.
Updated initial transactions load to load 30 transactions, also show more loads 30 more each time.
Updated /wallet to point to the new wallet, with new header and transaction table.
Adjusted e2e tests where needed, due to the changes on behavior.

How has this been tested?

On /wallet it should have the new header and transactions table with load more button, clicking on a transaction should take the user to /explorer/transactions instead of how it was before.
On /dashboard clicking on a transaction should also take the user to the /explorer/transactions.
The /explorer/account, should keep the old table and the infinite scrolling, to load more.

Review checklist

@renatomassao renatomassao self-assigned this Feb 5, 2019

@renatomassao renatomassao added this to Pull Requests in Version 1.11.0 via automation Feb 5, 2019

renatomassao added some commits Feb 6, 2019

@slaweet
Copy link
Member

slaweet left a comment

Thank you, Massao 🥇

@slaweet slaweet requested a review from Efefefef Feb 6, 2019

@Efefefef
Copy link
Contributor

Efefefef left a comment

🐛 Opening Wallet while non-transfer tx is pending results in error rendering
🐛 2pg reg tx - similar icon as transfer
@slaweet is there a task to restyle latest activity widget?

@slaweet

This comment has been minimized.

Copy link
Member

slaweet commented Feb 7, 2019

@Efefefef "Latest activity" widget on Dashboard will be updated in a few sprints when we do the new UX of Dashboard.

@Efefefef Efefefef added the ready label Feb 7, 2019

@renatomassao renatomassao merged commit e172f77 into 1.11.0 Feb 7, 2019

4 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
security/snyk - package.json (LiskHQ) No new issues
Details

Version 1.11.0 automation moved this from Pull Requests to Merged Pull Requests Feb 7, 2019

@renatomassao renatomassao deleted the 1705-replace-old-wallet-with-new-wallet branch Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment