New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable actions/transactions tests - Close #1750 #1751

Merged
merged 2 commits into from Feb 8, 2019

Conversation

Projects
3 participants
@renatomassao
Copy link
Contributor

renatomassao commented Feb 8, 2019

What issue have I solved?

#1750

How have I implemented/fixed it?

Removed path from the testPathIgnorePatterns of jest.config.js.
And adjusted were needed, because of the apis now returning a different format as was expected, and also added some options that were needed on the state.peers.

How has this been tested?

Running tests should also run the tests for actions/transactions and don't break any.

Review checklist

@renatomassao renatomassao self-assigned this Feb 8, 2019

@renatomassao renatomassao requested a review from Efefefef Feb 8, 2019

@renatomassao renatomassao added this to Pull Requests in Version 1.11.0 via automation Feb 8, 2019

@Efefefef

This comment has been minimized.

Copy link
Contributor

Efefefef commented Feb 8, 2019

We need somebody else's review here, cause I am not 100% sure how it works

@osvaldovega
Copy link
Contributor

osvaldovega left a comment

looks good

@Efefefef Efefefef added ready and removed ☑️ pending QA labels Feb 8, 2019

@renatomassao renatomassao merged commit a3d99bf into 1.11.0 Feb 8, 2019

4 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
security/snyk - package.json (LiskHQ) No new issues
Details

Version 1.11.0 automation moved this from Pull Requests to Merged Pull Requests Feb 8, 2019

@renatomassao renatomassao deleted the 1750-reenable-actions-transactions-test branch Feb 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment