Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal extension system - Closes #1710 #1709 #1740 #1790

Merged
merged 43 commits into from Mar 22, 2019

Conversation

Projects
None yet
4 participants
@michaeltomasik
Copy link
Member

commented Feb 19, 2019

What issue have I solved?

#1710 #1709 #1740

How have I implemented/fixed it?

How has this been tested?

Go to http://localhost:8080/#/extensions
Add one of:
https://codepen.io/michaeltomasik/pen/JxweXa.js
https://codepen.io/michaeltomasik/pen/rPoXGE.js

https://codepen.io/michaeltomasik/pen/jdXgBp.js <--- Not compiled component

It should add modules to a dashboard ONLY if you are on a development env

Review checklist

slaweet and others added some commits Feb 3, 2019

@michaeltomasik michaeltomasik added this to the Version 1.12.0 milestone Feb 19, 2019

@michaeltomasik michaeltomasik self-assigned this Feb 19, 2019

@michaeltomasik michaeltomasik added this to Pull Requests in Version 1.12.0 via automation Feb 19, 2019

@michaeltomasik michaeltomasik requested review from massao, osvaldovega and Efefefef and removed request for osvaldovega Feb 19, 2019

@slaweet slaweet removed this from the Version 1.12.0 milestone Feb 20, 2019

michaeltomasik added some commits Feb 20, 2019

@massao
Copy link
Contributor

left a comment

When removing an already loaded extension, it doesn't remove it from the dashboard

@slaweet slaweet requested a review from Efefefef Mar 5, 2019

@Efefefef
Copy link
Contributor

left a comment

Please adjust the message
'https://raw.githubusercontent.com/michaeltomasik/extensions-lisk/master/'
Right now first thing I want to do is to navigate to this url, which returns an invalid response message
Lets provide ? https://github.com/michaeltomasik/extensions-lisk
And put there extension guide
Btw where is it ? I cant find it

image

@Efefefef

This comment has been minimized.

Copy link
Contributor

commented Mar 5, 2019

@slaweet Can you update the specification? I am not aware of what I should test

michaeltomasik added some commits Mar 5, 2019

@michaeltomasik michaeltomasik changed the title Minimal extension system - Closes #1710 Minimal extension system - Closes #1710 #1709 #1740 Mar 5, 2019

@slaweet slaweet changed the base branch from 1.13.0 to 1.14.0 Mar 11, 2019

@slaweet

This comment has been minimized.

Copy link
Member

commented Mar 11, 2019

@Efefefef I've added the last point to #1709 .
I have the feeling it isn't much detailed, but I can't think of what else is missing?

@Efefefef

This comment has been minimized.

Copy link
Contributor

commented Mar 11, 2019

@slaweet What exactly should be disabled in the production mode?

@slaweet

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

@Efefefef I've put more details to #1709 to answer your question.
@michaeltomasik, please implement the extra message and disabled button mentioned there.

michaeltomasik added some commits Mar 21, 2019

michaeltomasik added some commits Mar 22, 2019

@slaweet
Copy link
Member

left a comment

The margin-botom on Box components is good.

@Efefefef Efefefef added the ready label Mar 22, 2019

@michaeltomasik michaeltomasik merged commit d37a82b into 1.14.0 Mar 22, 2019

5 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls Coverage remained the same at 94.124%
Details
security/snyk - package.json (LiskHQ) No new issues
Details

@michaeltomasik michaeltomasik deleted the minimal-extension-system branch Mar 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.