Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement send view transfer view - closes #1711 #1799

Merged
merged 11 commits into from Mar 6, 2019

Conversation

Projects
None yet
2 participants
@osvaldovega
Copy link
Contributor

osvaldovega commented Feb 27, 2019

What issue have I solved?

-- #1711

How have I implemented/fixed it?

This PR includes the form where the user add the address or bookmark account name, the amount and the reference is the form validates that inputs to see if the data is correct, if everything is correct the button is enable to continue

How has this been tested?

once that the send form is loaded, you can check that the button is disabled so the user it is not able to continue, if there is no bookmarks account the user needs to enter a valid address in case that write something invalid a error message and icon will be display.

In case that there are bookmark accounts that user can type some words or digits of the address and a list will show up where the user can see what bookmarks are available, in case that something is wrong is error message and icon will be display if everything is ok the icon will be green.

The same logic apply for the amount input and reference that it is optional.

After everything be properly fill and correct the button will be enable.

NOTE: For test this you need to change the browser URL from http://localhost:8080/#/wallet/send to http://localhost:8080/#/wallet/sendV2

Review checklist

osvaldovega added some commits Feb 25, 2019

@osvaldovega osvaldovega self-assigned this Feb 27, 2019

@osvaldovega osvaldovega requested a review from massao Feb 27, 2019

osvaldovega added some commits Feb 28, 2019

@osvaldovega osvaldovega changed the base branch from 1.13.0 to development Feb 28, 2019

@osvaldovega osvaldovega changed the base branch from development to 1.13.0 Feb 28, 2019

osvaldovega added some commits Feb 28, 2019

Show resolved Hide resolved src/components/bookmarkV2/bookmark.css Outdated
Show resolved Hide resolved src/components/bookmarkV2/bookmark.css Outdated
Show resolved Hide resolved src/components/bookmarkV2/bookmark.css Outdated
Show resolved Hide resolved src/components/bookmarkV2/bookmark.css Outdated
Show resolved Hide resolved src/components/bookmarkV2/bookmark.test.js Outdated
Show resolved Hide resolved src/components/sendV2/form/form.js
Show resolved Hide resolved src/components/sendV2/form/form.test.js
Show resolved Hide resolved src/components/sendV2/form/form.test.js
Show resolved Hide resolved src/components/sendV2/form/form.test.js
Show resolved Hide resolved src/components/sendV2/send.css Outdated
@osvaldovega

This comment has been minimized.

Copy link
Contributor Author

osvaldovega commented Mar 5, 2019

@renatomassao I just update the files based on the changes requested by you, I just checked that unit test and code work properly so right now everything is ok.

@massao

massao approved these changes Mar 5, 2019

Copy link
Contributor

massao left a comment

Just check with marketing if all texts are correct.

@osvaldovega

This comment has been minimized.

Copy link
Contributor Author

osvaldovega commented Mar 6, 2019

Yes yesterday they gave me the correct test

@massao massao added the ready label Mar 6, 2019

@osvaldovega osvaldovega merged commit 44c2a29 into 1.13.0 Mar 6, 2019

5 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls First build on PR-1799 at 93.983%
Details
security/snyk - package.json (LiskHQ) No manifest changes detected

@osvaldovega osvaldovega deleted the 1711-implement-send-view-transfer-view branch Mar 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.