Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement send view summary view - closes #1712 #1802

Merged
merged 5 commits into from Mar 7, 2019

Conversation

Projects
None yet
3 participants
@osvaldovega
Copy link
Contributor

osvaldovega commented Mar 4, 2019

What issue have I solved?

-- #1712

How have I implemented/fixed it?

This PR includes de files for the summary view page after the user fill the send transaction form.
this will show the recipient name and address the amount the converted to USD and the reference test too.
In case the user has a second passphrase the page will show you the second passphrase row where you can write it.

NOTE: The next button is working but not redirect to nothing because the next page it is not implemented yet.

How has this been tested?

Open the app.
go to wallet -> do click on send button
change the URL from ..send?wallet to sendV2?wallet
fill the form and then do click on the next button.
then you will see the summary page.

for test the second passphrase you need to login with this passphrase, "awkward service glimpse punch genre calm grow life bullet boil match like" and for the second the passphrase use this one, "forest around decrease farm vanish permit hotel clay senior matter endorse domain"

Review checklist

osvaldovega added some commits Mar 3, 2019

@osvaldovega osvaldovega self-assigned this Mar 4, 2019

@osvaldovega osvaldovega requested a review from massao Mar 4, 2019

Show resolved Hide resolved src/components/sendV2/form/form.test.js Outdated
Show resolved Hide resolved src/components/sendV2/summary/summary.js Outdated
Show resolved Hide resolved src/components/sendV2/summary/summary.test.js Outdated
Show resolved Hide resolved src/components/sendV2/summary/summary.test.js Outdated
Show resolved Hide resolved src/components/sendV2/summary/summary.test.js Outdated
Show resolved Hide resolved src/components/sendV2/summary/summary.js Outdated
Show resolved Hide resolved src/components/sendV2/send.js Outdated
@osvaldovega

This comment has been minimized.

Copy link
Contributor Author

osvaldovega commented Mar 5, 2019

@renatomassao @michaeltomasik thx guys for the feedback I just finish all the changes if you want to check it again just to confirm that everything is ok again.

@michaeltomasik
Copy link
Member

michaeltomasik left a comment

Looks good 🎉

Show resolved Hide resolved i18n/locales/en/common.json Outdated
Show resolved Hide resolved src/components/sendV2/form/form.test.js
Show resolved Hide resolved src/components/sendV2/form/form.test.js
Show resolved Hide resolved src/components/sendV2/send.js
Show resolved Hide resolved src/components/sendV2/send.test.js Outdated
Show resolved Hide resolved src/components/sendV2/summary/summary.js

osvaldovega added some commits Mar 5, 2019

@osvaldovega

This comment has been minimized.

Copy link
Contributor Author

osvaldovega commented Mar 5, 2019

@renatomassao I just fixed the other changes in the files and unit tests

@massao

massao approved these changes Mar 6, 2019

@massao massao added the ready label Mar 6, 2019

@osvaldovega osvaldovega changed the base branch from 1711-implement-send-view-transfer-view to 1.13.0 Mar 6, 2019

@osvaldovega osvaldovega merged commit cf20bb3 into 1.13.0 Mar 7, 2019

5 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls Coverage increased (+0.2%) to 94.03%
Details
security/snyk - package.json (LiskHQ) No manifest changes detected

@osvaldovega osvaldovega deleted the 1712-implement-send-view-summary-view branch Mar 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.