Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement basic balance chart in wallet - Closes #1745 #1804

Merged
merged 37 commits into from Mar 13, 2019

Conversation

Projects
None yet
3 participants
@massao
Copy link
Contributor

massao commented Mar 6, 2019

What issue have I solved?

#1745

How have I implemented/fixed it?

Implemented basic balance chart with data from the last transactions.
Chart tries to group by Day and Month if there are more than a specific number of transactions.
There are no unit tests for this feature right now, due to an issue with canvas API in the jsdom.

How has this been tested?

To a better visualization of the chart, connect to mainnet and check some delegate accounts with the route /explorer/accountsV2/[address].
The graph xAxes labels may overlap due to having many transactions in a short period of time, or if some transactions are from a lot of time ago.

Review checklist

massao added some commits Mar 5, 2019

@massao massao self-assigned this Mar 6, 2019

massao added some commits Mar 6, 2019

@massao massao requested review from slaweet and osvaldovega Mar 6, 2019

massao added some commits Mar 6, 2019

@osvaldovega
Copy link
Contributor

osvaldovega left a comment

looks good man, just a few changes

massao added some commits Mar 7, 2019

Merge pull request #1810 from LiskHQ/1805-implement-follow-account-dr…
…opdown

Implement Follow Account Dropdown - Closes #1805

massao added some commits Mar 6, 2019

Merge branch '1745-implement-basic-balance-chart-in-wallet' of github…
….com:LiskHQ/lisk-hub into 1745-implement-basic-balance-chart-in-wallet

@massao massao changed the base branch from 1.13.0 to development Mar 7, 2019

@massao massao changed the base branch from development to 1.13.0 Mar 7, 2019

@massao

This comment has been minimized.

Copy link
Contributor Author

massao commented Mar 7, 2019

@osvaldovega Fixed what was requested, and as discussed we will discuss about the destructuring on the next technical meeting

@massao massao requested a review from osvaldovega Mar 7, 2019

@slaweet slaweet changed the base branch from 1.13.0 to 1.14.0 Mar 11, 2019

@osvaldovega
Copy link
Contributor

osvaldovega left a comment

OK changes are done, and we need to discuss the destructuring in the meeting but the code looks good

@massao massao requested a review from Efefefef Mar 11, 2019

@Efefefef
Copy link
Contributor

Efefefef left a comment

@massao

This comment has been minimized.

Copy link
Contributor Author

massao commented Mar 12, 2019

@Efefefef As discussed pushed some code to try and fix the issue wit the white bar appearing:
image

@Efefefef

This comment has been minimized.

Copy link
Contributor

Efefefef commented Mar 12, 2019

Looks good for me

@massao massao requested a review from Efefefef Mar 12, 2019

@Efefefef Efefefef added the ready label Mar 13, 2019

@massao massao merged commit f542a2d into 1.14.0 Mar 13, 2019

4 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
security/snyk - package.json (LiskHQ) No new issues
Details

@massao massao deleted the 1745-implement-basic-balance-chart-in-wallet branch Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.