Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement send submitted view - closes #1713 #1809

Merged
merged 3 commits into from Mar 12, 2019

Conversation

Projects
None yet
3 participants
@osvaldovega
Copy link
Contributor

osvaldovega commented Mar 6, 2019

What issue have I solved?

-- #1713

How have I implemented/fixed it?

This PR include the component transactionStatus, in this page we check if the transaction pass or failed and based on that we present the the option to go back to wallet in case of success or send an error report email in case or error.

NOTE: This PR doesn't include the followed Account feature because some functionalities are not available yet.

How has this been tested?

Open the app.
go to wallet -> do click on send button
change the URL from ..send?wallet to sendV2?wallet
fill the form and then do click on the next button.
then you will see the summary page.
Then after check that everything is ok do a click on the submit transaction and then you
will see the transactionStatus, with the success status and go to wallet button.

Review checklist

@osvaldovega osvaldovega self-assigned this Mar 6, 2019

@osvaldovega osvaldovega requested a review from massao Mar 6, 2019

@slaweet slaweet changed the base branch from 1712-implement-send-view-summary-view to 1.14.0 Mar 11, 2019

@massao
Copy link
Contributor

massao left a comment

Just a few issues, but it's working perfectly 👍

Show resolved Hide resolved i18n/locales/en/common.json
Show resolved Hide resolved src/components/bookmarkV2/index.js Outdated
Show resolved Hide resolved src/components/bookmarkV2/index.js Outdated
Show resolved Hide resolved src/components/bookmarkV2/index.js Outdated
Show resolved Hide resolved src/components/sendV2/send.test.js Outdated
Show resolved Hide resolved src/components/sendV2/send.test.js Outdated
Show resolved Hide resolved src/components/sendV2/transactionStatus/transactionStatus.js
Show resolved Hide resolved src/components/sendV2/transactionStatus/transactionStatus.js Outdated
@osvaldovega

This comment has been minimized.

Copy link
Contributor Author

osvaldovega commented Mar 12, 2019

thx guys for all the feedback I made all those changes and now looks good, I think :)

@massao

massao approved these changes Mar 12, 2019

@massao massao added the ready label Mar 12, 2019

@osvaldovega osvaldovega merged commit 2d72f2e into 1.14.0 Mar 12, 2019

4 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
security/snyk - package.json (LiskHQ) No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.