Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Follow Account Dropdown - Closes #1805 #1810

Merged
merged 13 commits into from Mar 7, 2019

Conversation

Projects
None yet
2 participants
@massao
Copy link
Contributor

massao commented Mar 6, 2019

What issue have I solved?

#1805

How have I implemented/fixed it?

Created FollowAccount component that has the form for adding a new followed account, validates the length of the inputed name.
Show on dashboard is as readonly for now.
If account already followed, should show a different button for opening the dropdown, and show the saved account name, and a danger button.

How has this been tested?

Search any account on the search bar, on the account page, change explorer/accounts/ at the URL to explorer/accountsV2/, follow/following button should be on header.

Review checklist

massao added some commits Mar 6, 2019

@massao massao self-assigned this Mar 6, 2019

massao added some commits Mar 7, 2019

@massao massao requested a review from osvaldovega Mar 7, 2019

massao added some commits Mar 7, 2019

@osvaldovega
Copy link
Contributor

osvaldovega left a comment

looks great, just a few changes.

Show resolved Hide resolved src/components/followAccount/followAccount.js
Show resolved Hide resolved src/components/followAccount/index.js Outdated
Show resolved Hide resolved src/components/toolbox/buttons/css/baseV2.css

massao added some commits Mar 7, 2019

@massao massao force-pushed the 1805-implement-follow-account-dropdown branch from 0b056d0 to d4c71b0 Mar 7, 2019

@massao massao requested a review from osvaldovega Mar 7, 2019

@osvaldovega
Copy link
Contributor

osvaldovega left a comment

ok looks good, can check the destructuring in the tech meeting

@osvaldovega osvaldovega added the ready label Mar 7, 2019

@massao massao merged commit 71b56cd into 1.13.0 Mar 7, 2019

5 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls Coverage remained the same at 94.037%
Details
security/snyk - package.json (LiskHQ) No manifest changes detected

@massao massao deleted the 1805-implement-follow-account-dropdown branch Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.