Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement read only delegate tab - Closes #1778 #1812

Merged
merged 19 commits into from Mar 15, 2019

Conversation

Projects
None yet
2 participants
@massao
Copy link
Contributor

massao commented Mar 11, 2019

What issue have I solved?

#1778

How have I implemented/fixed it?

Implemented request to API to get the register delegate transaction and last block forged.
Created DelegateTab component, that displays all informations.
As discussed with @sansus we are showing the Last Forged Block as DateTime, with the same format used in the wallet (DD MMM YY, HH:mm).
If there is no last Forged block, it should appear as -

How has this been tested?

Search any delegate account, and change the URL to /explorer/accountsV2/:address, the delegate tab should be loaded besides the wallet tab.

Review checklist

@massao massao self-assigned this Mar 11, 2019

massao added some commits Mar 11, 2019

@massao massao requested a review from osvaldovega Mar 12, 2019

massao added some commits Mar 12, 2019

@massao massao force-pushed the 1778-implement-read-only-delegate-tab branch from 2a60c6d to 40a7082 Mar 12, 2019

massao added some commits Mar 12, 2019

@massao massao changed the base branch from 1.14.0 to development Mar 12, 2019

@massao massao changed the base branch from development to 1.14.0 Mar 12, 2019

@osvaldovega
Copy link
Contributor

osvaldovega left a comment

great man, just a few minor things.

massao added some commits Mar 14, 2019

@massao massao requested a review from osvaldovega Mar 14, 2019

massao added some commits Mar 15, 2019

@osvaldovega
Copy link
Contributor

osvaldovega left a comment

perfect.   👍🏻

@osvaldovega osvaldovega added the ready label Mar 15, 2019

@massao massao merged commit f9d4b18 into 1.14.0 Mar 15, 2019

5 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls Coverage decreased (-0.03%) to 94.126%
Details
security/snyk - package.json (LiskHQ) No manifest changes detected

@massao massao deleted the 1778-implement-read-only-delegate-tab branch Mar 15, 2019

@massao massao restored the 1778-implement-read-only-delegate-tab branch Mar 15, 2019

@massao massao deleted the 1778-implement-read-only-delegate-tab branch Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.