Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement send lsk with ledger in the new design - closes #1811 #1814

Merged
merged 4 commits into from Mar 13, 2019

Conversation

Projects
None yet
2 participants
@osvaldovega
Copy link
Contributor

osvaldovega commented Mar 11, 2019

What issue have I solved?

-- #1811

How have I implemented/fixed it?

This PR include the support to check when the HW is connected and sending LSK to another account so in the summary component there is a validation to wait for ledger confirmation or cancellation, then based on the action of the user the last step will show an error message for wallet or success, in case of error in the final step a retry button will show up to go back and then check the transaction again and accepted in case of user wanted.

How has this been tested?

For this you need to use the HW and run the app in electron.
Then login using the HW.
and change the URL address to go sendV2/, from there you need to send a LSK and then in the summary part the user needs to use the ledger to accept or cancel the transaction.

Review checklist

@osvaldovega osvaldovega self-assigned this Mar 11, 2019

@osvaldovega osvaldovega requested a review from massao Mar 11, 2019

osvaldovega added some commits Mar 11, 2019

@massao
Copy link
Contributor

massao left a comment

Nice job 👍
Just some comments about translations and code style.

Show resolved Hide resolved src/components/sendV2/summary/summary.js Outdated
Show resolved Hide resolved src/components/sendV2/summary/summary.js Outdated
Show resolved Hide resolved src/components/sendV2/summary/summary.js Outdated
Show resolved Hide resolved src/components/sendV2/summary/summary.js Outdated
Show resolved Hide resolved src/components/sendV2/summary/summary.js Outdated
Show resolved Hide resolved src/components/sendV2/summary/summary.test.js Outdated
Show resolved Hide resolved src/components/sendV2/summary/summary.test.js Outdated
Show resolved Hide resolved src/components/sendV2/transactionStatus/statusMessages.js Outdated
Show resolved Hide resolved src/components/sendV2/transactionStatus/transactionStatus.js Outdated
Show resolved Hide resolved src/components/sendV2/transactionStatus/transactionStatus.test.js Outdated
@massao

massao approved these changes Mar 13, 2019

Copy link
Contributor

massao left a comment

Great job! 👍

@massao massao added the ready label Mar 13, 2019

@osvaldovega osvaldovega merged commit 6b96208 into 1713-implement-send-submitted-view Mar 13, 2019

4 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
security/snyk - package.json (LiskHQ) No manifest changes detected

@osvaldovega osvaldovega deleted the 1811-implement-send-lsk-with-ledger-in-the-new-design branch Mar 13, 2019

@osvaldovega osvaldovega restored the 1811-implement-send-lsk-with-ledger-in-the-new-design branch Mar 13, 2019

@osvaldovega osvaldovega deleted the 1811-implement-send-lsk-with-ledger-in-the-new-design branch Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.