Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update request reference field to use bytes to count length #1815

Merged
merged 1 commit into from Mar 12, 2019

Conversation

Projects
None yet
3 participants
@massao
Copy link
Contributor

massao commented Mar 12, 2019

How have I implemented/fixed it?

Updated reference field to use bytes instead of value.length, due to different languages having different byte count for characters.

How has this been tested?

Go to /wallet and click on request LSK and change the reference field
Updated and checked that everything still works as expected.

Review checklist

@massao massao self-assigned this Mar 12, 2019

@massao massao requested review from slaweet and osvaldovega Mar 12, 2019

@osvaldovega
Copy link
Contributor

osvaldovega left a comment

good, looks good

@massao massao requested a review from Efefefef Mar 12, 2019

@Efefefef Efefefef added the ready label Mar 12, 2019

@massao massao merged commit 2b3f4a1 into 1.13.0 Mar 12, 2019

5 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls First build on PR-1815 at 94.039%
Details
security/snyk - package.json (LiskHQ) No manifest changes detected

@massao massao deleted the update-request-message-to-use-bytes branch Mar 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.