New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace old send page with new new one - Closes #1743 #1817
Replace old send page with new new one - Closes #1743 #1817
Conversation
…ased on the path or page selected
…ger-in-the-new-design Implement send lsk with ledger in the new design - closes #1811
…ased on the path or page selected
…ased on the path or page selected
… of github.com:LiskHQ/lisk-hub into 1806-implement-follow-account-dropdown-send-component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments
…com:LiskHQ/lisk-hub into 1743-replace-old-send-page-with-new-new-one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the comment above. Why you put |
@Efefefef I update the bookmark labels with the correct text, I just checked with @slaweet. |
🐛 Create First Transaction from Initialize Lisk ID widget doesn't fill in the fields |
@osvaldovega @Efefefef Account bookmarked button should be only displayed in the flow the user bookmarked the account. It should not be displayed the next time the user sends to that address. |
Ok guys then there is a bug |
@Efefefef can you please check all the functionality related the send component and confirm that everything else is working as should be, in case something else it is not working properly can you please put it in just one update, then I don't need to to fix just one bug and after that you check again the code and find another one. In case this is the last bug, can you please confirm this is the last thing to fix then I can proceed to fix it? |
👍 Good to go! |
🐛 Man you accidentally removed the link that prepopulates fields |
What issue have I solved?
-- #1743
How have I implemented/fixed it?
In this PR the routes file has been update to redirect to the folder that contains the new version (design) of the send page.
Then update the E2E tests that are related to the send page, all the tests for this page were update
How has this been tested?
Open the app the go to wallet and do a click on the send button, this will display the new version of send and then user can go through the process.
You can send and LSK by typing address or selecting one if there is a bookmark already or using the HW ledger.
Review checklist