Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace old send page with new new one - Closes #1743 #1817

Merged
merged 42 commits into from Mar 22, 2019

Conversation

Projects
None yet
4 participants
@osvaldovega
Copy link
Contributor

commented Mar 12, 2019

What issue have I solved?

-- #1743

How have I implemented/fixed it?

In this PR the routes file has been update to redirect to the folder that contains the new version (design) of the send page.

Then update the E2E tests that are related to the send page, all the tests for this page were update

How has this been tested?

Open the app the go to wallet and do a click on the send button, this will display the new version of send and then user can go through the process.
You can send and LSK by typing address or selecting one if there is a bookmark already or using the HW ledger.

Review checklist

osvaldovega added some commits Mar 11, 2019

@osvaldovega osvaldovega self-assigned this Mar 12, 2019

osvaldovega added some commits Mar 13, 2019

@slaweet

This comment has been minimized.

Copy link
Member

commented Mar 13, 2019

I quickly tried it out and found these two things to fix:

  • Top bar "My wallet" icon shold be also blue
  • "Edit transaction" doesn't keep the values. Clicking it will go to the previous step with all inputs empty.
    Screen Shot 2019-03-13 at 10 20 44

osvaldovega added some commits Mar 13, 2019

Merge pull request #1814 from LiskHQ/1811-implement-send-lsk-with-led…
…ger-in-the-new-design

Implement send lsk with ledger in the new design - closes #1811

@osvaldovega osvaldovega changed the base branch from 1713-implement-send-submitted-view to 1.14.0 Mar 14, 2019

@osvaldovega osvaldovega requested a review from massao Mar 14, 2019

osvaldovega added some commits Mar 11, 2019

Merge branch '1806-implement-follow-account-dropdown-send-component'…
… of github.com:LiskHQ/lisk-hub into 1806-implement-follow-account-dropdown-send-component
@massao
Copy link
Contributor

left a comment

Just a few comments

Show resolved Hide resolved src/components/sendV2/summary/summary.js
Show resolved Hide resolved src/components/sendV2/summary/summary.js Outdated
Show resolved Hide resolved src/components/sendV2/summary/summary.test.js Outdated
Show resolved Hide resolved test/cypress/utils/enterSecondPassphrase.js Outdated

osvaldovega added some commits Mar 19, 2019

Merge branch '1743-replace-old-send-page-with-new-new-one' of github.…
…com:LiskHQ/lisk-hub into 1743-replace-old-send-page-with-new-new-one

@osvaldovega osvaldovega requested a review from Efefefef Mar 19, 2019

@Efefefef
Copy link
Contributor

left a comment

Please consider my comment above, it contains actual bugs

🐛 Byte counter is broken. try entering 🇩🇪
🐛 Tooltip's wrong tip's direction

image

🐛 Typo
image

@Efefefef

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

🐛
Should be bookmarked account
image

@Efefefef

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

Uncaught (in promise) Error: Status 404 : Delegate not found is still not fixed

Please check the comment above. Why you put bookmark account, not bookmarked account ?

@osvaldovega

This comment has been minimized.

Copy link
Contributor Author

commented Mar 21, 2019

@Efefefef I update the bookmark labels with the correct text, I just checked with @slaweet.
About the error message in the console, that is a problem with the lisk core, I need to create a ticket with them it is not related to us because the problem is randomly, thats why I didn't saw it before submit the PR the last time and then you saw it now. it is not all the times that happen

@Efefefef

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

🐛 Create First Transaction from Initialize Lisk ID widget doesn't fill in the fields
@slaweet Should we show Account bookmarked button on Confirmation page if that was an already bookmarked account?
image

@osvaldovega

This comment has been minimized.

Copy link
Contributor Author

commented Mar 21, 2019

@Efefefef In the meetings that we have for check this designs Daria already mentioned that only is displayed when the account it is not part of the bookmarks list, so if account is already in the bookmark list we don't show the button.
cc @slaweet

@slaweet

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

@osvaldovega @Efefefef Account bookmarked button should be only displayed in the flow the user bookmarked the account. It should not be displayed the next time the user sends to that address.

@Efefefef

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

Ok guys then there is a bug
🐛 If you click Send to the acc from account's page then you'll see the bookmarked dialog shown

@osvaldovega

This comment has been minimized.

Copy link
Contributor Author

commented Mar 21, 2019

@Efefefef can you please check all the functionality related the send component and confirm that everything else is working as should be, in case something else it is not working properly can you please put it in just one update, then I don't need to to fix just one bug and after that you check again the code and find another one.

In case this is the last bug, can you please confirm this is the last thing to fix then I can proceed to fix it?

osvaldovega added some commits Mar 21, 2019

@Efefefef

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2019

👍 Good to go!

osvaldovega added some commits Mar 22, 2019

@Efefefef

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2019

🐛 Man you accidentally removed the link that prepopulates fields

@osvaldovega osvaldovega merged commit a630a92 into 1.14.0 Mar 22, 2019

4 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
security/snyk - package.json (LiskHQ) No new issues
Details

@osvaldovega osvaldovega deleted the 1743-replace-old-send-page-with-new-new-one branch Mar 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.