Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement votes tab on account page - Closes #1779 #1818

Closed
wants to merge 29 commits into
base: 1.14.0
from

Conversation

Projects
None yet
1 participant
@massao
Copy link
Contributor

massao commented Mar 13, 2019

What issue have I solved?

#1779

How have I implemented/fixed it?

Implemented Votes tab on another account page, that consumes the votes api to show the data, loading additional data for delegates will be handled in a follow up ticket: #1820

How has this been tested?

Go to /explorer/accountsV2/:address of some account and check if:

  • it has more than 30 it should appear the show more button at the bottom;
  • it has no votes should show a message.

The filter should filter by username:

  • If a username meets the criteria it should show up;
  • if no username meets the criteria, a message shows up.

Review checklist

@massao massao self-assigned this Mar 13, 2019

massao added some commits Mar 13, 2019

@massao massao requested a review from osvaldovega Mar 14, 2019

massao added some commits Mar 14, 2019

Merge branch '1779-implement-votes-tab-on-account-page' of github.com…
…:LiskHQ/lisk-hub into 1779-implement-votes-tab-on-account-page

@massao massao changed the base branch from 1778-implement-read-only-delegate-tab to 1.14.0 Mar 15, 2019

@massao massao changed the base branch from 1.14.0 to development Mar 15, 2019

@massao massao changed the base branch from development to 1.14.0 Mar 15, 2019

@massao massao changed the base branch from 1.14.0 to development Mar 15, 2019

@massao massao changed the base branch from development to 1.14.0 Mar 15, 2019

@massao massao closed this Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.