Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement follow account dropdown send component - closes #1806 #1823

Conversation

Projects
None yet
3 participants
@osvaldovega
Copy link
Contributor

commented Mar 15, 2019

What issue have I solved?

-- #1806

How have I implemented/fixed it?

This PR include the follow account feature after send some LSKs to any account in case that account it is not in your followed accounts already.

This is just a dropdown feature that permit to the user add a name of the recipient account and then follow it or unfollow.

How has this been tested?

The only way to test this is try to send some LSKs to any accounts following the process in the send page, and in the last page where the transaction sent successfully will see a button in the left for follow the account in case that it is not in the list already.

NOTE: if you select an account for the bookmark list in the send page (in the form page) this button will not be display because that is already followed, so this button it is only enable for all those new accounts that are not part or the follow account list.

Review checklist

massao and others added some commits Mar 5, 2019

Merge pull request #1799 from LiskHQ/1711-implement-send-view-transfe…
…r-view

Implement send view transfer view - closes #1711
Merge pull request #1802 from LiskHQ/1712-implement-send-view-summary…
…-view

Implement send view summary view - closes #1712
Merge pull request #1810 from LiskHQ/1805-implement-follow-account-dr…
…opdown

Implement Follow Account Dropdown - Closes #1805

massao and others added some commits Mar 6, 2019

Merge branch '1745-implement-basic-balance-chart-in-wallet' of github…
….com:LiskHQ/lisk-hub into 1745-implement-basic-balance-chart-in-wallet
Merge pull request #1804 from LiskHQ/1745-implement-basic-balance-cha…
…rt-in-wallet

Implement basic balance chart in wallet - Closes #1745
Merge branch '1806-implement-follow-account-dropdown-send-component'…
… of github.com:LiskHQ/lisk-hub into 1806-implement-follow-account-dropdown-send-component

@osvaldovega osvaldovega self-assigned this Mar 15, 2019

@osvaldovega osvaldovega requested a review from massao Mar 15, 2019

@massao
Copy link
Contributor

left a comment

Just one small thing

Show resolved Hide resolved src/components/bookmarkV2/index.js Outdated

osvaldovega added some commits Mar 15, 2019

@massao

massao approved these changes Mar 15, 2019

@osvaldovega osvaldovega changed the base branch from 1.14.0 to 1743-replace-old-send-page-with-new-new-one Mar 15, 2019

@osvaldovega osvaldovega merged commit ca632fc into 1743-replace-old-send-page-with-new-new-one Mar 15, 2019

4 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
security/snyk - package.json (LiskHQ) No manifest changes detected

@osvaldovega osvaldovega deleted the 1806-implement-follow-account-dropdown-send-component branch Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.