Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace old account page with new one - Closes #1780 #1827

Merged
merged 19 commits into from Mar 22, 2019

Conversation

Projects
None yet
4 participants
@massao
Copy link
Contributor

commented Mar 18, 2019

What issue have I solved?

#1780

How have I implemented/fixed it?

Replaced old account page with new one, and updated wallet to have votes tab, and delegate tab when needed.

How has this been tested?

Search any account in the search bar, and should open on the new layout.
Search delegate account, and should show the delegate tab on the new layout.
Wallet page should have Votes tab.
Login with a delegate account, and the delegate tab should appear on the wallet page.

Review checklist

massao added some commits Mar 18, 2019

@massao massao self-assigned this Mar 18, 2019

massao added some commits Mar 18, 2019

@massao massao requested a review from osvaldovega Mar 19, 2019

@osvaldovega
Copy link
Contributor

left a comment

all are minor things, everything else looks good

Show resolved Hide resolved test/constants/selectors.js Outdated
Show resolved Hide resolved test/cypress/e2e/account.spec.js Outdated
Show resolved Hide resolved test/cypress/e2e/activity.spec.js Outdated
Show resolved Hide resolved test/cypress/e2e/activity.spec.js Outdated

@massao massao requested a review from osvaldovega Mar 20, 2019

@osvaldovega
Copy link
Contributor

left a comment

nice Massao, I saw the changes.

@Efefefef

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

@slaweet No specification

@Efefefef

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

@slaweet
1)Why wallet not account?
image
2) Last forged block - date or countdown?
3) Where shoul I be redirected after clicking Send LSK to this Wallet (again why Wallet? (4)) and completing the transaction? My wallet or his wallet?
5) How Filter be name on Votes tab should work?
🐛 It is said that "On your dashboard" checkbox should not be present now #1805
🐛 Follower -> Bookmark #1805
🐛 Account name text field got the green validation mark inside

@slaweet

This comment has been minimized.

Copy link
Member

commented Mar 22, 2019

Good feedback, @Efefefef.
1), 4) - let's align the terminology and use "Account" in these places instead of "Wallet"
Screen Shot 2019-03-22 at 09 16 58 1

2 ) Date is ok for last block (I see it was different in design)

3 ) Should redirect to "My wallet"

5 ) updated on #1780

massao added some commits Mar 22, 2019

@massao massao requested a review from Efefefef Mar 22, 2019

massao added some commits Mar 22, 2019

@Efefefef
Copy link
Contributor

left a comment

👍

@Efefefef Efefefef added the ready label Mar 22, 2019

@massao massao merged commit 1fbbb7f into 1.14.0 Mar 22, 2019

5 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls Coverage remained the same at 94.121%
Details
security/snyk - package.json (LiskHQ) No manifest changes detected

@massao massao deleted the 1780-replace-old-account-page branch Mar 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.