Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace old account page with new one - Closes #1780 #1827

Merged
merged 19 commits into from Mar 22, 2019
Merged
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
1449c84
:recycle: Add delegate and votes tab to wallet
massao Mar 18, 2019
17bc4ef
:recycle: Point explorer/account to new version
massao Mar 18, 2019
5c4ab9e
:white_check_mark: Adjust e2e tests for new account page
massao Mar 18, 2019
359cf43
:recycle: Adjust style for votesTab and when to fetch new data
massao Mar 18, 2019
25b3915
:white_check_mark: Adjust unit tests
massao Mar 18, 2019
5fca420
:white_check_mark: Adjust e2e tests
massao Mar 18, 2019
58093bc
:fire: Remove old account page files
massao Mar 18, 2019
8310add
:white_check_mark: Add delegate test to walletTransactionsV2 file
massao Mar 18, 2019
46b910d
:white_check_mark: Make cypress scroll so first row is not blocked
massao Mar 18, 2019
88d813c
:fire: Remove send files used on old account page
massao Mar 18, 2019
51dc834
:white_check_mark: Fix test being unskipped wrongly
massao Mar 18, 2019
7a611f2
:white_check_mark: Adjust e2e tests
massao Mar 18, 2019
3a1dda2
:white_check_mark: Fix e2e tests due to change on selector
massao Mar 18, 2019
40955be
:recycle: Adjust as requested per review
massao Mar 20, 2019
92933b6
:recycle: Adjust as requested per QA review
massao Mar 22, 2019
309dc5a
:recycle: Remove global scoped graph plugin on balance chart
massao Mar 22, 2019
4d3c1b2
:white_check_mark: Adjust tests after QA review fixes
massao Mar 22, 2019
634f37b
Merge branch '1.14.0' into 1780-replace-old-account-page
massao Mar 22, 2019
a4618d7
:recycle: Update to use since last login instead of visit
massao Mar 22, 2019
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

Make cypress scroll so first row is not blocked

  • Loading branch information...
massao committed Mar 18, 2019
commit 46b910d58d693602d2ecea0b4e0bbb95de53303f
@@ -59,6 +59,7 @@ function testActivity(open) {
describe('Account info tab', () => {
beforeEach(() => {
cy.autologin(accounts.genesis.passphrase, networks.devnet.node);
cy.visit('/dashboard');
This conversation was marked as resolved by massao

This comment has been minimized.

Copy link
@osvaldovega

osvaldovega Mar 20, 2019

Contributor

here you can use constants too

open();
waitBeforeChangeTabAfterLoading();
cy.get(ss.accountInfoTab).click();
@@ -91,7 +92,9 @@ function testActivity(open) {
* @expect corresponding delegate name is shown on account's page
*/
it('Click on voted delegate leads to account page', () => {
cy.get(ss.voteRow).eq(0).scrollIntoView().click();
cy.scrollTo('top');
cy.get(ss.voteRow).eq(0).click();
cy.wait(3000);
cy.get(ss.delegateName).should('have.text', 'genesis_17');
});
});
@@ -111,7 +114,7 @@ function testDelegateActivity(open) {
* list if the account is a delegate
* @expect voters nickname shown
*/
xit('Shows voters nickname if it is delegate', () => {
it('Shows voters nickname if it is delegate', () => {
cy.get(ss.voterAddress).eq(0).should('have.text', 'genesis_1 ');
});

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.