Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement back forward buttons in the top bar - closes #1807 #1829

Merged

Conversation

Projects
None yet
3 participants
@osvaldovega
Copy link
Contributor

commented Mar 18, 2019

What issue have I solved?

-- #1807

How have I implemented/fixed it?

This PR include the functionality of use back and forward buttons for navigation in the app. This buttons are located in the topBar component and only are shown in the extra large and large views.

How has this been tested?

For this the user should be login into the application and only in here the buttons will be enable in the login or registration there is no functionality.

If the user is logout the navigation will work only for those available pages.

Review checklist

osvaldovega added some commits Mar 18, 2019

@osvaldovega osvaldovega self-assigned this Mar 18, 2019

@osvaldovega osvaldovega requested a review from massao Mar 18, 2019

osvaldovega added some commits Mar 19, 2019

@massao
Copy link
Contributor

left a comment

Just some small stuffs

Show resolved Hide resolved src/components/topBar/navigationButtons.css
Show resolved Hide resolved src/components/topBar/navigationButtons.js Outdated
Show resolved Hide resolved src/components/topBar/navigationButtons.js Outdated
Show resolved Hide resolved src/components/topBar/navigationButtons.js Outdated
Show resolved Hide resolved src/components/topBar/navigationButtons.js Outdated
Show resolved Hide resolved src/components/topBar/navigationButtons.js Outdated
Show resolved Hide resolved src/components/topBar/navigationButtons.js Outdated
Show resolved Hide resolved src/components/topBar/navigationButtons.js Outdated

massao and others added some commits Mar 20, 2019

Merge branch '1807-implement-back-forward-buttons-in-the-top-bar' of …
…github.com:LiskHQ/lisk-hub into 1807-implement-back-forward-buttons-in-the-top-bar
@massao

massao approved these changes Mar 21, 2019

@massao massao requested a review from Efefefef Mar 21, 2019

@Efefefef
Copy link
Contributor

left a comment

👍 Great, no changes needed

@Efefefef Efefefef added the ready label Mar 22, 2019

@osvaldovega osvaldovega merged commit 18b5ac3 into 1.14.0 Mar 22, 2019

4 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
security/snyk - package.json (LiskHQ) No new issues
Details

@osvaldovega osvaldovega deleted the 1807-implement-back-forward-buttons-in-the-top-bar branch Mar 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.