Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create storybook structure - Closes 1830 #1850

Merged
merged 19 commits into from Apr 4, 2019

Conversation

Projects
None yet
4 participants
@massao
Copy link
Contributor

massao commented Mar 22, 2019

What issue have I solved?

#1830

How have I implemented/fixed it?

Created initial structure of storybook, with own package.json so the webpack configuration doesn't conflict with our own, since storybooks uses webpack 4.
Added alias to webpack to be easier to reference the components folder inside stories. Components alias.
Created buttons stories with action addons as initial example.
Added storybook script to package.json to be easier to run storybook from the root folder.

Improvements

  • Need to check which addons we want to use, and that are relevant to us. addons;
  • New components stories should be added as they are updated.

How has this been tested?

Install dependencies of storybook on /storybook folder with npm i, after you can run npm run storybook at the root of the project or on the /storybook folder, and the storybook should open on a browser tab.

Review checklist

massao added some commits Mar 21, 2019

@massao massao self-assigned this Mar 22, 2019

@slaweet slaweet changed the base branch from development to 1.15.0 Mar 22, 2019

massao added some commits Mar 25, 2019

@michaeltomasik
Copy link
Member

michaeltomasik left a comment

👍 Thanks

@Efefefef

This comment has been minimized.

Copy link
Contributor

Efefefef commented Mar 26, 2019

@massao I have errors running storybook
Failed to load preset: "/Users/andreiklimenok/lisk/hub/node_modules/@storybook/react/dist/server/framework-preset-cra.js" ERR! TypeError: Cannot destructure property createHash of 'undefined' or 'null'.

@slaweet
Copy link
Member

slaweet left a comment

Great work done, @massao.
Just two minor details below.

Show resolved Hide resolved package.json Outdated
Show resolved Hide resolved storybook/stories/buttons.stories.js Outdated
Update package.json
Co-Authored-By: massao <rmy.yonamine@gmail.com>

massao added some commits Apr 3, 2019

massao and others added some commits Mar 21, 2019

Update package.json
Co-Authored-By: massao <rmy.yonamine@gmail.com>
Merge branch '1830-create-storybook-structure' of github.com:LiskHQ/l…
…isk-hub into 1830-create-storybook-structure

@massao massao changed the base branch from 1.15.0 to development Apr 3, 2019

@massao massao changed the base branch from development to 1.15.0 Apr 3, 2019

@slaweet

slaweet approved these changes Apr 4, 2019

Copy link
Member

slaweet left a comment

👍

@slaweet slaweet added the ready label Apr 4, 2019

@massao massao merged commit 6ee5e74 into 1.15.0 Apr 4, 2019

4 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
security/snyk - package.json (LiskHQ) No new issues
Details

@massao massao deleted the 1830-create-storybook-structure branch Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.