Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate splash screen to final ui - Closes #1834 #1853

Merged
merged 15 commits into from Mar 27, 2019

Conversation

Projects
None yet
2 participants
@massao
Copy link
Contributor

commented Mar 25, 2019

What issue have I solved?

#1834

How have I implemented/fixed it?

Migrated splash screen to final UI.

PR #1852 - Should be merged before this one.

How has this been tested?

Go to the / without being logged in, and the splash screen should have the final UI design, with dark background.

Review checklist

massao added some commits Mar 25, 2019

@massao massao self-assigned this Mar 25, 2019

@massao massao requested review from osvaldovega and michaeltomasik Mar 25, 2019

massao added some commits Mar 25, 2019

Merge branch '1834-migrate-splash-screen-to-final-ui' of github.com:L…
…iskHQ/lisk-hub into 1834-migrate-splash-screen-to-final-ui

@massao massao changed the base branch from 1.15.0 to 1838-migrate-wallet-header-to-final-UI Mar 25, 2019

massao added some commits Mar 25, 2019

@massao massao force-pushed the 1834-migrate-splash-screen-to-final-ui branch from 9731ff2 to 5ebf5d3 Mar 26, 2019

@michaeltomasik
Copy link
Member

left a comment

Good Job 😄 👍

@michaeltomasik michaeltomasik requested a review from Efefefef Mar 26, 2019

@massao massao changed the base branch from 1838-migrate-wallet-header-to-final-UI to 1.15.0 Mar 26, 2019

@massao massao added ready and removed ready labels Mar 26, 2019

@massao massao requested review from michaeltomasik and removed request for Efefefef Mar 26, 2019

@michaeltomasik
Copy link
Member

left a comment

👍 Thank you

@massao massao merged commit 8f751f6 into 1.15.0 Mar 27, 2019

4 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
security/snyk - package.json (LiskHQ) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.