Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate login pages to final ui - Closes #1836 #1862

Merged
merged 32 commits into from Apr 1, 2019

Conversation

Projects
None yet
3 participants
@massao
Copy link
Contributor

massao commented Mar 26, 2019

What issue have I solved?

#1836

How have I implemented/fixed it?

  • Updated headerV2 to have the final UI on the Login page;
  • Create tertiary button as it is on the styleguide;
  • Create Feedback component to have a consistent feedback message;
  • Update dropdown component and tooltip component to final UI;
  • Update Login page to final UI.

How has this been tested?

Go to /login page, and it should have the final UI, including tooltip, dropdown, feedback messages.

Review checklist

massao added some commits Mar 26, 2019

@massao massao self-assigned this Mar 26, 2019

@massao massao requested review from osvaldovega and michaeltomasik Mar 26, 2019

massao added some commits Mar 26, 2019

massao added some commits Mar 26, 2019

Merge branch '1836-migrate-login-pages-to-final-ui' of github.com:Lis…
…kHQ/lisk-hub into 1836-migrate-login-pages-to-final-ui

@massao massao force-pushed the 1836-migrate-login-pages-to-final-ui branch from b1b09f4 to 9805fc8 Mar 26, 2019

@massao massao changed the base branch from 1834-migrate-splash-screen-to-final-ui to 1.15.0 Mar 27, 2019

@slaweet slaweet modified the milestone: Version 1.15.0 Mar 29, 2019

@osvaldovega
Copy link
Contributor

osvaldovega left a comment

looks good, just one minor thing

@osvaldovega
Copy link
Contributor

osvaldovega left a comment

🏆

@massao massao requested review from Efefefef and removed request for Efefefef Apr 1, 2019

@massao massao added the ready label Apr 1, 2019

@massao massao merged commit 61ad2f4 into 1.15.0 Apr 1, 2019

3 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

@massao massao deleted the 1836-migrate-login-pages-to-final-ui branch Apr 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.