Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate wallet tab to Final UI - Closes #1839 #1863

Merged
merged 23 commits into from Apr 4, 2019

Conversation

Projects
None yet
3 participants
@massao
Copy link
Contributor

massao commented Mar 26, 2019

What issue have I solved?

#1839

How have I implemented/fixed it?

  • Migrated wallet detail module to final UI;
  • Adjusted balance chart colors to the final UI;
  • Updated filter transctions dropdown to final UI;
  • Migrated transactions table to final UI;
  • Refactored and improved structure of css.

How has this been tested?

Go to /wallet page and it should have the final UI design, and all the functionalities should still be the same

Review checklist

@massao massao self-assigned this Mar 26, 2019

massao added some commits Mar 26, 2019

@slaweet slaweet modified the milestone: Version 1.15.0 Mar 29, 2019

massao added some commits Apr 1, 2019

@massao massao requested review from michaeltomasik and osvaldovega Apr 3, 2019

@osvaldovega
Copy link
Contributor

osvaldovega left a comment

nice work man. Minor details, that I think could be change but check it and then let me know

Show resolved Hide resolved src/components/requestV2/requestV2.js Outdated
</span>
<Feedback
className={`${styles.feedback} ${styles.referenceFeedback}`}
show={!!fields.reference.feedback}

This comment has been minimized.

Copy link
@osvaldovega

osvaldovega Apr 4, 2019

Contributor

same here

This comment has been minimized.

Copy link
@massao

massao Apr 4, 2019

Author Contributor

Not on this one, because it's should show the feedback message even if it doesn't have an error.

</span>
<Feedback
className={styles.feedback}
show={!!this.state.feedback}

This comment has been minimized.

Copy link
@osvaldovega

osvaldovega Apr 4, 2019

Contributor

I think in here you can use error value too, as it is a bool

This comment has been minimized.

Copy link
@massao

massao Apr 4, 2019

Author Contributor

On this case it would be needed to test both fields error value, this way we only need to check if we have a feedback message for any of the fields.

</span>
<Feedback
className={styles.feedback}
show={!!this.state.feedback}

This comment has been minimized.

Copy link
@osvaldovega

osvaldovega Apr 4, 2019

Contributor

here too

This comment has been minimized.

Copy link
@massao

massao Apr 4, 2019

Author Contributor

On this case it would be needed to test both fields error value, this way we only need to check if we have a feedback message for any of the fields.

Show resolved Hide resolved src/components/transactionsV2/filters/messageFieldGroup.js Outdated
@osvaldovega
Copy link
Contributor

osvaldovega left a comment

ok nice work 🎟

@osvaldovega osvaldovega added the ready label Apr 4, 2019

@massao massao merged commit 266580e into 1.15.0 Apr 4, 2019

4 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
security/snyk - package.json (LiskHQ) No new issues
Details

@massao massao deleted the 1839-migrate-wallet-tab-to-final-ui branch Apr 4, 2019

@massao massao restored the 1839-migrate-wallet-tab-to-final-ui branch Apr 4, 2019

@massao massao deleted the 1839-migrate-wallet-tab-to-final-ui branch Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.