Implement the new search - Closes #1774 #1813 #1864
What issue have I solved?
How have I implemented/fixed it?
This PR includes the new design of the search bar component what involve the following changes.
NOTE: The search logic for this component needs to be improve to provide the information need as the mockups, so right now some mockups show so information that right now we dont have.
How has this been tested?
For test this component, the user needs to login into the application and then do a click on the search icon on the topBar (final element at the right).
Then type something to search for like and account address, delegate or transactions ID.
NOTE: Please take in consideration that based on the actual search logic it is not possible to present or view this component as the new design mockups, once the search logic be improve the user will be able to see the results as the mock ups, for now it is not possible. The improvement will be implemented in a different PR.
Efefefef left a comment
Hi @Efefefef about your review I fixed the labels as you mentioned, however as I mentioned in the PR note in the top, right now the search bar it is not able to see it as the mockups because the search it is not retrieving some information that it is need it for work properly and display the information.
In other words, we right now do not have message label column because at this point it is not possible to search by message, so all those title/label related to message are not showing the information that you see in the mock ups so the first thing is the at this point it is not possible search or display something related to message and second as @slaweet mentioned.
This is actually ok. I forgot to mention it in specs, but it is an exception from the design, as Balance requires additional API request.
So I just update the PR based on your review, please check it again and in case you have any doubt just let me know and we can check it with Vit.
By the way the idea is that in another ticket we need to improve the search function that retrieve the information to be possible to search any information like in the mockups
About the message: sorry for not being clear enough, I meant that the placeholder string should be changed, not the functionality.
Hi @Efefefef after review the search.spec.js file again I just realized that I made a big mistake with the classes and assertions as you mentioned, right now I just fixed all of them and confirm the asserting is making in a properly way, I remove unnecessary comments and additional data, please check it again and let me know if right now it is ok