Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overlapping labels on balance chart - Closes #1858 #1869

merged 11 commits into from Apr 5, 2019


None yet
3 participants
Copy link

massao commented Mar 28, 2019

What issue have I solved?


How have I implemented/fixed it?

Group transactions in a per day basis so the labels don't overlap and we can present in a linear and not series way.

How has this been tested?

  1. Login for someone who had many transactions in same month
  2. Go to wallet
  3. Labels shouldn't overlap.

Review checklist

@massao massao self-assigned this Mar 28, 2019

@massao massao requested review from michaeltomasik and osvaldovega Mar 28, 2019

Copy link

osvaldovega left a comment

🏆 nice job

@osvaldovega osvaldovega requested a review from Efefefef Mar 28, 2019

Copy link

Efefefef left a comment

This is what i get with many txs

@massao massao requested a review from Efefefef Mar 29, 2019

massao added some commits Mar 29, 2019

@slaweet slaweet changed the base branch from 1.14.0 to 1.15.0 Mar 29, 2019


This comment has been minimized.

Copy link

Efefefef commented Apr 1, 2019

This one needs improvement or consideration

massao added some commits Apr 4, 2019

@massao massao force-pushed the 1858-fix-overlapping-labels-on-balance-chart branch from 7d39a17 to 27cd2c3 Apr 5, 2019

Copy link

Efefefef left a comment

👍 Now works very good, thank you!

@Efefefef Efefefef added the ready label Apr 5, 2019

@massao massao merged commit 5f641c5 into 1.15.0 Apr 5, 2019

3 of 4 checks passed

security/snyk - package.json (LiskHQ) 1 new vulnerable dependency path
Jenkins e2e tests e2e tests passed
Jenkins test deployment Commit was deployed to test
continuous-integration/jenkins/pr-merge This commit looks good

@massao massao deleted the 1858-fix-overlapping-labels-on-balance-chart branch Apr 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.