Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate send LSK to final UI - Closes #1842 #1879

Merged
merged 7 commits into from Apr 4, 2019

Conversation

Projects
None yet
3 participants
@osvaldovega
Copy link
Contributor

commented Apr 2, 2019

What issue have I solved?

-- #1842

How have I implemented/fixed it?

This PR is only for change the style of the send component to the final UI, no logic was change, only style (css)

How has this been tested?

After change the style, I proceed to send some lsk to a random account and bookmark account to see if everything is working properly after that.

For test this, you should follow the same usual procedure as before, nothing change.

Review checklist

@osvaldovega osvaldovega added this to the Version 1.15.0 milestone Apr 2, 2019

@osvaldovega osvaldovega self-assigned this Apr 2, 2019

@osvaldovega osvaldovega requested a review from massao Apr 2, 2019

@osvaldovega osvaldovega changed the title Migrate send lsk to final ui - Closes #1842 Migrate send LSK to final UI - Closes #1842 Apr 2, 2019

@massao
Copy link
Contributor

left a comment

Just some stuffs, also make sure that you update all the css variables to use the new ones.

Show resolved Hide resolved src/components/bookmarkV2/bookmark.css Outdated
Show resolved Hide resolved src/components/bookmarkV2/bookmark.css Outdated
Show resolved Hide resolved src/components/sendV2/form/form.css Outdated
Show resolved Hide resolved src/components/sendV2/form/form.css Outdated
Show resolved Hide resolved src/components/sendV2/form/form.css Outdated
Show resolved Hide resolved src/components/sendV2/form/form.css Outdated
Show resolved Hide resolved src/components/sendV2/form/form.css
Show resolved Hide resolved src/components/sendV2/form/form.test.js Outdated
Show resolved Hide resolved src/components/sendV2/summary/summary.css Outdated
Show resolved Hide resolved src/components/sendV2/summary/summary.css Outdated

osvaldovega added some commits Apr 3, 2019

@massao
Copy link
Contributor

left a comment

just one small thing

Show resolved Hide resolved src/components/bookmarkV2/bookmark.css Outdated
Update src/components/bookmarkV2/bookmark.css
Co-Authored-By: osvaldovega <osvaldo.vega@lightcurve.io>
@massao

massao approved these changes Apr 4, 2019

Copy link
Contributor

left a comment

🙆‍♂️

@massao massao added the ready label Apr 4, 2019

@osvaldovega osvaldovega merged commit 59e93f1 into 1.15.0 Apr 4, 2019

4 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
security/snyk - package.json (LiskHQ) No new issues
Details

@osvaldovega osvaldovega deleted the 1842-migrate-send-lsk-to-final-ui branch Apr 4, 2019

@slaweet slaweet removed this from the Version 1.15.0 milestone Apr 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.