Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate votes tab to final UI - Closes #1840 #1881

Merged
merged 1 commit into from Apr 4, 2019

Conversation

Projects
None yet
2 participants
@massao
Copy link
Contributor

massao commented Apr 3, 2019

What issue have I solved?

#1840

How have I implemented/fixed it?

Migrate vote tab to final UI, updated breaking points, updated colors and fonts styles

How has this been tested?

Go to /wallet and click on vote tab, should be rendered with the final UI, functionalities should be the same as before.

Review checklist

@massao massao self-assigned this Apr 3, 2019

@massao massao changed the base branch from 1839-migrate-wallet-tab-to-final-ui to 1.15.0 Apr 3, 2019

@massao massao requested review from michaeltomasik and osvaldovega Apr 3, 2019

@massao massao changed the base branch from 1.15.0 to development Apr 4, 2019

@massao massao changed the base branch from development to 1.15.0 Apr 4, 2019

@osvaldovega
Copy link
Contributor

osvaldovega left a comment

looks good to me... 🎲

@osvaldovega osvaldovega added the ready label Apr 4, 2019

@massao massao merged commit 054ed50 into 1.15.0 Apr 4, 2019

5 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls Coverage remained the same at 94.09%
Details
security/snyk - package.json (LiskHQ) No manifest changes detected

@massao massao deleted the 1840-migrate-votes-tab-to-final-ui branch Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.