Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate transaction detail page to final UI - Closes #1841 #1883

Merged
merged 5 commits into from Apr 4, 2019

Conversation

Projects
None yet
2 participants
@massao
Copy link
Contributor

massao commented Apr 3, 2019

What issue have I solved?

#1841

How have I implemented/fixed it?

Migrated transaction detail page to final UI, and updated unit tests where needed.

How has this been tested?

Open any transaction and the design should be the final UI.
transfer, 2nd passphrase registration, delegate registration and voting transactions should have the new design.

Review checklist

massao added some commits Apr 3, 2019

@massao massao self-assigned this Apr 3, 2019

@massao massao requested review from michaeltomasik and osvaldovega Apr 3, 2019

@massao massao changed the base branch from 1839-migrate-wallet-tab-to-final-ui to 1.15.0 Apr 3, 2019

@massao massao changed the base branch from 1.15.0 to development Apr 4, 2019

@massao massao changed the base branch from development to 1.15.0 Apr 4, 2019

@osvaldovega
Copy link
Contributor

osvaldovega left a comment

nice work man.... 🏋🏻‍♂️

@osvaldovega osvaldovega added the ready label Apr 4, 2019

@massao massao merged commit 1a80bf9 into 1.15.0 Apr 4, 2019

4 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
security/snyk - package.json (LiskHQ) No new issues
Details

@massao massao deleted the 1841-migrate-tx-detail-page-to-final-UI branch Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.