Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix send LSK navigation data form - Closes #1906 #1905 #1907

Merged
merged 3 commits into from Apr 9, 2019

Conversation

Projects
None yet
3 participants
@osvaldovega
Copy link
Contributor

osvaldovega commented Apr 5, 2019

What issue have I solved?

-- #1906
-- #1905

How have I implemented/fixed it?

This PR include the fix for the send LSK form so know works properly.

From the Wallet table select any address (click)
Once the send LSK form page show up, type any amount and message, (the message it is option but is better for testing purposes).
Do click in the "Go to Confirmation" button
Then from the confirmation button go back to the previous page
Then the amount and message fields are populated with the provided information.

How has this been tested?

Like this.
From the Wallet table select any address (click)
Once the send LSK form page show up, type any amount and message, (the message it is option but is better for testing purposes).
Do click in the "Go to Confirmation" button
Then from the confirmation button go back to the previous page
Then the amount and message fields are populated with the provided information.

Review checklist

@osvaldovega osvaldovega self-assigned this Apr 5, 2019

@osvaldovega osvaldovega requested a review from massao Apr 5, 2019

@slaweet slaweet changed the base branch from development to 1.15.0 Apr 5, 2019

@massao
Copy link
Contributor

massao left a comment

💯

@Efefefef Efefefef self-requested a review Apr 8, 2019

@Efefefef
Copy link
Contributor

Efefefef left a comment

🐛 0.0 is considered to be a valid amount
🐛 sent to account does not prefill anything at all now 🦀
Next time some testing would be nice before creating pr

osvaldovega added some commits Apr 8, 2019

@massao

massao approved these changes Apr 9, 2019

@massao massao requested a review from Efefefef Apr 9, 2019

@Efefefef
Copy link
Contributor

Efefefef left a comment

👍

@Efefefef Efefefef added the ready label Apr 9, 2019

@osvaldovega osvaldovega merged commit d84f07b into 1.15.0 Apr 9, 2019

4 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
security/snyk - package.json (LiskHQ) No new issues
Details

@osvaldovega osvaldovega deleted the 1906-fix-send-LSK-navigation-data-form branch Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.