Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegate account shows account before delegate name - Closes #1899 #1909

Merged

Conversation

Projects
None yet
3 participants
@massao
Copy link
Contributor

commented Apr 8, 2019

What issue have I solved?

#1899

How have I implemented/fixed it?

Since we have the username when the request for the account info is finished, already display, without waiting for other delegate data.

How has this been tested?

Go to a delegate account page, and the name should show up faster than before.
It's not possible to show directly the delegate username since we need to wait for the request for account data to finish.

Review checklist

massao added some commits Apr 8, 2019

@massao massao self-assigned this Apr 8, 2019

@massao massao requested a review from osvaldovega Apr 8, 2019

@osvaldovega
Copy link
Contributor

left a comment

nicely done... 🥇

@osvaldovega osvaldovega requested a review from Efefefef Apr 8, 2019

@Efefefef
Copy link
Contributor

left a comment

Cool

@Efefefef Efefefef added the ready label Apr 9, 2019

@massao massao dismissed stale reviews from Efefefef and osvaldovega via 83273da Apr 9, 2019

@Efefefef Efefefef self-requested a review Apr 9, 2019

@Efefefef
Copy link
Contributor

left a comment

👍

@massao massao merged commit a5e4304 into 1.16.0 Apr 9, 2019

5 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls Coverage remained the same at 94.147%
Details
security/snyk - package.json (LiskHQ) No manifest changes detected

@massao massao deleted the 1899-delegate-account-shows-account-before-delegate-name branch Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.