Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction list filtering not working properly - Closes #1912 #1915

Merged
merged 3 commits into from Apr 10, 2019

Conversation

Projects
None yet
3 participants
@massao
Copy link
Contributor

massao commented Apr 9, 2019

What issue have I solved?

#1912

How have I implemented/fixed it?

The problem here was with the transctionUpdated action, since the filter was being changed after the request was sent, it was fetching the wrong data and dispatching to the store, so it got the filtered and the updated data mixed.
I added a condition to only dispatch to the store if the filter didn't change between the action being called and the data being fetched.

How has this been tested?

  1. Go to the wallet
  2. Click incoming/outgoing tabs until you get incoming tx in outgoing tab.

Tested with cypress locally a lot of times, and couldn't get the error to happen again, event when making the network slower.

Review checklist

@massao massao self-assigned this Apr 9, 2019

@massao massao requested review from osvaldovega and michaeltomasik Apr 9, 2019

@michaeltomasik
Copy link
Member

michaeltomasik left a comment

👍

@massao massao requested a review from Efefefef Apr 9, 2019

@Efefefef
Copy link
Contributor

Efefefef left a comment

🥇

@Efefefef Efefefef added the ready label Apr 10, 2019

@massao massao merged commit 6a1247f into 1.15.0 Apr 10, 2019

5 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls Coverage increased (+0.01%) to 94.151%
Details
security/snyk - package.json (LiskHQ) No manifest changes detected

@massao massao deleted the 1912-transaction-list-filtering-not-working-properly branch Apr 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.