Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Balance chart reflecting changes on transactions table - Closes #1913 #1916

Merged

Conversation

Projects
None yet
3 participants
@massao
Copy link
Contributor

massao commented Apr 9, 2019

What issue have I solved?

#1913

How have I implemented/fixed it?

Added condition to only update the balance chart when first getting transactions data. Afterwards the balance chart shouldn't update, only if leaving and revisiting the page.

How has this been tested?

  1. Go to My wallet
  2. Do some tx list filtering
  3. Balance chart shouldn't update.

Review checklist

massao added some commits Apr 9, 2019

@massao massao self-assigned this Apr 9, 2019

@massao massao requested review from michaeltomasik and osvaldovega Apr 9, 2019

@michaeltomasik
Copy link
Member

michaeltomasik left a comment

🙃 Thanks

@michaeltomasik michaeltomasik requested a review from Efefefef Apr 10, 2019

@Efefefef
Copy link
Contributor

Efefefef left a comment

🐛 Doesn't work as expected. Check somebody's graph out and switch herer and there

@Efefefef
Copy link
Contributor

Efefefef left a comment

👍

@Efefefef Efefefef added duplicate ready and removed duplicate labels Apr 10, 2019

@massao massao merged commit 124ac61 into 1.15.0 Apr 10, 2019

4 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
security/snyk - package.json (LiskHQ) No manifest changes detected

@massao massao deleted the 1913-balance-details-chart-reflects-transactions-filtering branch Apr 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.