Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No result screen showing before tx loaded - Closes #1882 #1917

Merged
merged 4 commits into from Apr 10, 2019

Conversation

Projects
None yet
3 participants
@massao
Copy link
Contributor

commented Apr 9, 2019

What issue have I solved?

#1882

How have I implemented/fixed it?

Added condition to only show the no result screen if request returns no result.

How has this been tested?

You can throttle the network to delay the loading of the tx.

  • Click on some tx in Wallet or use the direct link or use search suggestions to open valid tx.
  • No result screen should not flash before the tx loaded.

Review checklist

@massao massao self-assigned this Apr 9, 2019

@massao massao requested review from michaeltomasik and osvaldovega Apr 9, 2019

massao added some commits Apr 9, 2019

@osvaldovega
Copy link
Contributor

left a comment

nice just a few changes just that

@massao massao requested a review from osvaldovega Apr 10, 2019

@osvaldovega
Copy link
Contributor

left a comment

💰perfect

@osvaldovega osvaldovega requested a review from Efefefef Apr 10, 2019

@Efefefef
Copy link
Contributor

left a comment

👍

@Efefefef Efefefef added the ready label Apr 10, 2019

@massao massao merged commit b2efa1a into 1.16.0 Apr 10, 2019

5 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls Coverage remained the same at 94.164%
Details
security/snyk - package.json (LiskHQ) No manifest changes detected

@massao massao deleted the 1882-no-result-screen-before-tx-loaded branch Apr 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.