Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear all filters button too big - Closes #1922 #1923

Merged
merged 2 commits into from Apr 12, 2019

Conversation

Projects
None yet
3 participants
@massao
Copy link
Contributor

massao commented Apr 12, 2019

What issue have I solved?

#1922

How have I implemented/fixed it?

Added extra-small class variant to the clear all button, and fixed some spacing and alignment issues.

How has this been tested?

Go to wallet, and add some filters, the clear all button should have the same height as the filters labels.

Review checklist

massao added some commits Apr 12, 2019

@massao massao requested a review from osvaldovega Apr 12, 2019

@massao massao self-assigned this Apr 12, 2019

@osvaldovega
Copy link
Contributor

osvaldovega left a comment

🎉 nice

@osvaldovega osvaldovega requested a review from Efefefef Apr 12, 2019

@Efefefef Efefefef added the ready label Apr 12, 2019

@massao massao merged commit 8107378 into 1.15.0 Apr 12, 2019

5 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls First build on PR-1923 at 94.151%
Details
security/snyk - package.json (LiskHQ) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.