Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tooltip and login label on splash screen - Closes #1921 #1924

Merged
merged 5 commits into from Apr 12, 2019

Conversation

Projects
None yet
3 participants
@slaweet
Copy link
Member

slaweet commented Apr 12, 2019

What issue have I solved?

#1921

How have I implemented/fixed it?

  • Changed the text of Login button
  • Added the tooltip and changed the icon to be outside of the link, as IMO it doesn't make good UX if clicking the question mark icon at the same time can toggle the tooltip and navigate to the link destination.

How has this been tested?

  • Go to the splash screen to see the button label
  • hover the question mark icon to see the tooltip

Review checklist

slaweet added some commits Apr 12, 2019

@welcome

This comment has been minimized.

Copy link

welcome bot commented Apr 12, 2019

Thanks for opening this pull request! Please check out our contributing guidelines.

@slaweet slaweet self-assigned this Apr 12, 2019

@slaweet slaweet requested a review from massao Apr 12, 2019

@massao
Copy link
Contributor

massao left a comment

Maybe it's a good idea to update the tooltip.css file to use inherit the color and use the currentColor value as property for the border and ::before color.
So the icon has the same color as the context it's put into.

@slaweet

This comment has been minimized.

Copy link
Member Author

slaweet commented Apr 12, 2019

@massao I pushed a commit to make the icon blue. I didn't use currentColor because the splash screen is actually the only place where the question mark icon uses the color of the context. In other places, it's often a brighter gray than the text next to it, e.g. https://app.zeplin.io/project/5c82526ebf0d81bce46d5255/screen/5c8ba492d58aef056fabff93

@slaweet slaweet requested a review from massao Apr 12, 2019

@massao
Copy link
Contributor

massao left a comment

👍

@massao massao requested a review from Efefefef Apr 12, 2019

@Efefefef
Copy link
Contributor

Efefefef left a comment

Now you have Sign in in the button and logging in in the tooltip

@slaweet slaweet requested a review from Efefefef Apr 12, 2019

@Efefefef
Copy link
Contributor

Efefefef left a comment

👍

@Efefefef Efefefef added the ready label Apr 12, 2019

@slaweet slaweet merged commit 6ac355e into 1.15.0 Apr 12, 2019

4 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
security/snyk - package.json (LiskHQ) No manifest changes detected

@slaweet slaweet deleted the 1921-fix-splash-screen branch Apr 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.