Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create redux refactor proposal to store BTC data - Closes #1896 #1925

Merged

Conversation

Projects
None yet
4 participants
@massao
Copy link
Contributor

commented Apr 15, 2019

What issue have I solved?

#1896

How have I implemented/fixed it?

How has this been tested?

Review checklist

@massao massao self-assigned this Apr 15, 2019

massao added some commits Apr 15, 2019

@massao massao force-pushed the 1896-create-redux-refactor-proposal-to-store-BTC-data branch from b82d09d to b067346 Apr 16, 2019

massao added some commits Apr 16, 2019

Show resolved Hide resolved docs/REDUX_STRUCTURE.md
Show resolved Hide resolved docs/REDUX_STRUCTURE.md Outdated

@massao massao force-pushed the 1896-create-redux-refactor-proposal-to-store-BTC-data branch from 07a9eb8 to f2a2279 Apr 17, 2019

@slaweet slaweet changed the base branch from 1.16.0 to development Apr 18, 2019

massao added some commits Apr 18, 2019

"account": { "LSK account info" },
"accounts": { "info": { "BTC": {} }, "followed": {} },
"BTC": { "BTC specific data" },
"service": {},

This comment has been minimized.

Copy link
@yasharAyari

yasharAyari Apr 18, 2019

Member

This reducer needs to support multi token. the structure of this reducer should be similar accounts reduce. Also, lets the app to store dynamic fee system for BTC.

This comment has been minimized.

Copy link
@yasharAyari

yasharAyari Apr 18, 2019

Member

the service data structure should be like the below example :
service: { dynamicFees: {} , priceTicker: { "BTC": {}, "LSK": {} } };

massao added some commits Apr 18, 2019

@slaweet
Copy link
Member

left a comment

My feedback was resolved. Thanks, @massao

@slaweet slaweet added the ready label Apr 23, 2019

@slaweet slaweet merged commit b1bcdaa into development Apr 24, 2019

4 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
security/snyk - package.json (LiskHQ) No new issues
Details

@slaweet slaweet deleted the 1896-create-redux-refactor-proposal-to-store-BTC-data branch Apr 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.