Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove onboarding - Closes #1870 #1937

Merged
merged 1 commit into from Apr 17, 2019

Conversation

Projects
None yet
3 participants
@Efefefef
Copy link
Contributor

commented Apr 16, 2019

What issue have I solved?

#1870

How have I implemented/fixed it?

Remove all occurrences in components, CSS and tests

How has this been tested?

no localStorage parameter
no onboarding on help page
no error on login

Review checklist

@Efefefef Efefefef self-assigned this Apr 16, 2019

@Efefefef Efefefef requested a review from slaweet Apr 16, 2019

@Efefefef Efefefef force-pushed the 1870-remove-onboarding branch from deff823 to 07daa8f Apr 16, 2019

@slaweet
Copy link
Member

left a comment

Thank you, @Efefefef 👍

@slaweet slaweet requested a review from massao Apr 16, 2019

@massao

massao approved these changes Apr 16, 2019

Copy link
Contributor

left a comment

Nice work 🎉

@massao massao added the ready label Apr 16, 2019

@Efefefef Efefefef merged commit 32ac4e6 into 1.16.0 Apr 17, 2019

4 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
security/snyk - package.json (LiskHQ) No new issues
Details

@Efefefef Efefefef deleted the 1870-remove-onboarding branch Apr 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.