Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize search e2e - Closes #1938 #1939

Merged
merged 1 commit into from Apr 18, 2019

Conversation

Projects
None yet
2 participants
@Efefefef
Copy link
Contributor

commented Apr 17, 2019

What issue have I solved?

#1938

How have I implemented/fixed it?

Simplify assertions for net specific tests
Make use of waiting for slow requests such as /node/constants

How has this been tested?

Should not fail 5 times in a row in Jenkins

Review checklist

@Efefefef Efefefef added the type: test label Apr 17, 2019

@Efefefef Efefefef changed the base branch from development to 1.16.0 Apr 17, 2019

@Efefefef Efefefef marked this pull request as ready for review Apr 17, 2019

@slaweet slaweet removed the type: test label Apr 17, 2019

@Efefefef Efefefef self-assigned this Apr 17, 2019

@slaweet slaweet changed the base branch from 1.16.0 to development Apr 18, 2019

@slaweet
Copy link
Member

left a comment

Thank you, Andrei.

@slaweet slaweet added the ready label Apr 18, 2019

@slaweet slaweet merged commit 1c1bac6 into development Apr 18, 2019

5 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls Coverage remained the same at 94.147%
Details
security/snyk - package.json (LiskHQ) No new issues
Details

@slaweet slaweet deleted the 1938-stabilize-search-e2e branch Apr 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.