Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rerun failed e2e tests with recording - #1940 #1941

Merged
merged 10 commits into from May 15, 2019

Conversation

Projects
None yet
5 participants
@Efefefef
Copy link
Contributor

commented Apr 17, 2019

What issue have I solved?

#1940

How have I implemented/fixed it?

setup new project id

How has this been tested?

Review checklist

@Efefefef Efefefef self-assigned this Apr 17, 2019

@slaweet slaweet changed the base branch from 1.16.0 to development Apr 18, 2019

@fchavant fchavant requested a review from slaweet Apr 18, 2019

@fchavant fchavant assigned Efefefef and fchavant and unassigned Efefefef Apr 18, 2019

@slaweet
Copy link
Member

left a comment

The PR is good, but it can be merged only after @yasharAyari confirms that we have purchased at least the $100/month cypress subscription for our new Lisk cypress organization.

@Efefefef

This comment has been minimized.

Copy link
Contributor Author

commented Apr 23, 2019

@fchavant

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

@Efefefef the Jenkins build you linked ran before 9am while my last commit in this PR was around 1pm.

@Efefefef

This comment has been minimized.

Copy link
Contributor Author

commented Apr 23, 2019

@fchavant We must include the relative path to the test files for example
cypress run --project test/cypress --record --spec "test/cypress/e2e/send.spec.js"
https://ci.lisk.io/blue/organizations/jenkins/lisk-hub/detail/PR-1941/13/pipeline

@fchavant

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

@Efefefef how can I find out what the path of the spec file is? Can I assume it'll always be test/cypress/e2e/?

@Efefefef

This comment has been minimized.

Copy link
Contributor Author

commented Apr 23, 2019

@fchavant Yes

@fchavant

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

@Efefefef done in 77d6970

@Efefefef

This comment has been minimized.

Copy link
Contributor Author

commented Apr 23, 2019

👍 It Works

@fchavant fchavant requested review from Nazgolze and psychopenguin Apr 24, 2019

Efefefef and others added some commits Apr 17, 2019

Do not record cypress tests by default
If some tests fail, find out which ones and re-run those with
recording enabled.

@Efefefef Efefefef dismissed stale reviews from psychopenguin and Nazgolze via 3351189 May 15, 2019

@Efefefef Efefefef force-pushed the 1940-new-cypress-setup branch from b638ede to 3351189 May 15, 2019

Efefefef added some commits May 15, 2019

Merge branch 'development' into 1940-new-cypress-setup
# Conflicts:
#	test/cypress/e2e/wallet.spec.js

@Efefefef Efefefef requested a review from slaweet May 15, 2019

@slaweet
Copy link
Member

left a comment

Nice, @Efefefef, clear structure of splitting the tests into the files. 👍

@Efefefef Efefefef merged commit 7030b87 into development May 15, 2019

3 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

@Efefefef Efefefef deleted the 1940-new-cypress-setup branch May 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.