Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create developer guide for React components - Closes #1626 #1965

Merged
merged 6 commits into from Apr 30, 2019

Conversation

Projects
None yet
4 participants
@slaweet
Copy link
Member

commented Apr 29, 2019

What issue have I solved?

#1626

How have I implemented/fixed it?

I created the guide to describe what we agreed on in technical meetings

How has this been tested?

Open the guide and read it 馃槈

Review checklist

@slaweet slaweet self-assigned this Apr 29, 2019

slaweet added some commits Jan 3, 2019

@slaweet slaweet force-pushed the 1626-improve-guides branch from 2415aed to 5b3c4b8 Apr 29, 2019

@massao

massao approved these changes Apr 30, 2019

Copy link
Contributor

left a comment

馃帀

@osvaldovega
Copy link
Contributor

left a comment

馃拵perfect

@michaeltomasik
Copy link
Member

left a comment

Thank you 馃檹

@slaweet slaweet merged commit 1dd1445 into development Apr 30, 2019

4 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
security/snyk - package.json (LiskHQ) No manifest changes detected

@slaweet slaweet added the ready label Apr 30, 2019

@slaweet slaweet deleted the 1626-improve-guides branch May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.