Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement final ui pending action hw wallet - Closes #1932 #1970

Merged
merged 10 commits into from May 2, 2019

Conversation

Projects
None yet
3 participants
@massao
Copy link
Contributor

commented Apr 30, 2019

What issue have I solved?

#1932

How have I implemented/fixed it?

Moved device list to redux store to be easier to update views when devices are connected/disconnected.
Created page asking for user to open Lisk App on Ledger.
We won't have the page asking for the PIN on the trezor, since it's not feasible.

Known Issue:
The Ledger isn't recognized if it's connected after opening lisk-hub, will be fixed on follow up ticket (#1976 )

How has this been tested?

Review checklist

massao added some commits Apr 30, 2019

@massao massao self-assigned this Apr 30, 2019

massao added some commits May 2, 2019

@massao massao force-pushed the 1932-implement-final-ui-pending-action-hw-wallet branch from d9e1d33 to a99bac0 May 2, 2019

massao added some commits May 2, 2019

@massao massao requested a review from osvaldovega May 2, 2019

massao added some commits May 2, 2019

@massao massao force-pushed the 1932-implement-final-ui-pending-action-hw-wallet branch from 231493b to 9eab748 May 2, 2019

@osvaldovega
Copy link
Contributor

left a comment

🏋🏻‍♂️Looks good

@massao massao added the ready label May 2, 2019

@massao massao merged commit 83eb7aa into development May 2, 2019

5 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls First build on PR-1970 at 94.424%
Details
security/snyk - package.json (LiskHQ) No manifest changes detected

@massao massao deleted the 1932-implement-final-ui-pending-action-hw-wallet branch May 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.