Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ledger detection - Closes #1976 #1978

Merged

Conversation

Projects
None yet
2 participants
@massao
Copy link
Contributor

commented May 2, 2019

What issue have I solved?

#1976

How have I implemented/fixed it?

Updated how the Ledger connection was being detected, to only check if it is connected, instead of checking if the Lisk App is open, and added a function to be able to update the device on the open App screen, passing an event through ipc.
And handling going back on the multistep component if the devices are disconnected.

Known Issue: Detecting that the app was opened is buggy, because of how the events of Ledger are recognize by the HID, every time the app is open or closed, it sends a remove and add event to the USB

How has this been tested?

  1. Run this build on electron
  2. Go to /hw-wallet-login-v2
  3. Connect and unlock Ledger
  4. Should go to the page asking for opening the app on ledger.
  5. Opening the app should go to select account page.

Review checklist

@massao massao self-assigned this May 2, 2019

@massao massao changed the base branch from development to 1934-implement-final-ui-of-list-of-HW-accounts-page May 3, 2019

@massao massao changed the base branch from 1934-implement-final-ui-of-list-of-HW-accounts-page to development May 3, 2019

massao added some commits May 2, 2019

@massao massao force-pushed the 1976-fix-ledger-not-being-recognize-after-hub-is-open branch from 03da0fe to db379c3 May 3, 2019

@massao massao requested review from osvaldovega and michaeltomasik May 3, 2019

massao added some commits May 3, 2019

@osvaldovega
Copy link
Contributor

left a comment

Looks good just a minor thing

*/
export const devicesListUpdated = data => ({
data,
type: actionTypes.devicesListUpdate,

This comment has been minimized.

Copy link
@osvaldovega

osvaldovega May 7, 2019

Contributor

I don't know if this is a typo but looks like the function name is past time a this function action not devicesListUpdated.

In the other hand I dont know if should be something like updateDevicesList... what do you think?

This comment has been minimized.

Copy link
@massao

massao May 7, 2019

Author Contributor

Update to follow the same standard as we use in other actions and reducers

@massao massao requested a review from osvaldovega May 7, 2019

@osvaldovega
Copy link
Contributor

left a comment

🥇looks good

@osvaldovega osvaldovega added the ready label May 7, 2019

@massao massao merged commit d7a1dee into development May 8, 2019

4 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
security/snyk - package.json (LiskHQ) No new issues
Details

@massao massao deleted the 1976-fix-ledger-not-being-recognize-after-hub-is-open branch May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.