Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement select hardware wallet device screen - closes #1931 #1979

Merged

Conversation

Projects
None yet
2 participants
@osvaldovega
Copy link
Contributor

commented May 2, 2019

What issue have I solved?

-- #1931

How have I implemented/fixed it?

The feature just include the link in the splash screen for login with HW and the selected hwWallet device if there is more than 1, what will cause the user will see the list of connected devices and the user is able to select what hwWallet will use.

If the user do a click in the Go Back button will go to the splash screen, but if the user disconnect all hwWallet devices will go back automatically to the loading screen (previous screen).

How has this been tested?

Review checklist

osvaldovega added some commits May 2, 2019

Merge remote-tracking branch 'origin/1932-implement-final-ui-pending-…
…action-hw-wallet' into 1931-implement-select-hardware-wallet-device-screen

@osvaldovega osvaldovega requested a review from massao May 2, 2019

@osvaldovega osvaldovega self-assigned this May 2, 2019

@massao
Copy link
Contributor

left a comment

👍

@massao

massao approved these changes May 2, 2019

@osvaldovega osvaldovega merged commit ef5396d into development May 2, 2019

5 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls First build on PR-1979 at 94.421%
Details
security/snyk - package.json (LiskHQ) No manifest changes detected

@osvaldovega osvaldovega deleted the 1931-implement-select-hardware-wallet-device-screen branch May 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.