Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ecstatic version missing - Closes #1980 #1981

Merged
merged 1 commit into from May 3, 2019

Conversation

Projects
None yet
4 participants
@massao
Copy link
Contributor

commented May 3, 2019

What issue have I solved?

#1980

How have I implemented/fixed it?

Added correct version as githash on package.json as a temporary solution.

How has this been tested?

Review checklist

@massao massao self-assigned this May 3, 2019

@massao massao requested review from slaweet and Efefefef May 3, 2019

@slaweet

slaweet approved these changes May 3, 2019

Copy link
Member

left a comment

Neat solution 🥇

@Efefefef
Copy link
Contributor

left a comment

👍

@Efefefef Efefefef added the ready label May 3, 2019

@yasharAyari yasharAyari merged commit 39c53d3 into development May 3, 2019

5 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls First build on PR-1981 at 94.421%
Details
security/snyk - package.json (LiskHQ) No new issues
Details

@yasharAyari yasharAyari deleted the 1980-fix-ecstatic-version-missing branch May 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.