Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new design delegate table - Closes #1961 #1985

Merged
merged 28 commits into from May 14, 2019

Conversation

Projects
None yet
3 participants
@michaeltomasik
Copy link
Member

commented May 6, 2019

What issue have I solved?

#1961

How have I implemented/fixed it?

How has this been tested?

Review checklist

michaeltomasik added some commits May 3, 2019

@michaeltomasik michaeltomasik self-assigned this May 6, 2019

michaeltomasik added some commits May 7, 2019

@michaeltomasik michaeltomasik requested review from massao and osvaldovega May 10, 2019

@massao
Copy link
Contributor

left a comment

Some comments, and also some of the css files could be shortened a bit, since there are some rules that don't apply to the new design.

@@ -0,0 +1,39 @@
import React from 'react';
import { expect } from 'chai';

This comment has been minimized.

Copy link
@massao

massao May 10, 2019

Contributor

Should be using jest instead of chai

Show resolved Hide resolved src/components/votingListViewV2/delegateListV2.js Outdated
Show resolved Hide resolved src/components/votingListViewV2/delegateRowV2.js Outdated
Show resolved Hide resolved src/components/votingListViewV2/delegateRowV2.js Outdated
Show resolved Hide resolved src/components/votingListViewV2/index.test.js Outdated
Show resolved Hide resolved src/components/votingListViewV2/votingHeaderV2.css Outdated
Show resolved Hide resolved src/components/votingListViewV2/votingListViewV2.css Outdated
Show resolved Hide resolved src/components/votingListViewV2/votingListViewV2.js Outdated
Show resolved Hide resolved src/components/votingListViewV2/votingListViewV2.js Outdated
Show resolved Hide resolved src/components/votingV2/votingV2.css

michaeltomasik added some commits May 12, 2019

@osvaldovega osvaldovega removed their request for review May 13, 2019

@massao
Copy link
Contributor

left a comment

Just some small visual stuffs:

  • 🐛 The checkbox should be thinner and grey when unselected, similar to the one at the Sign In page;
  • 🐛 The table has a horizontal scroll;
  • 🐛 To keep it consistent with the other tables, the scroll shouldn't be inside the table but on the body itself, similar to the wallet page;
    image
  • 🐛 The table shouldn't have the box-shadow anymore;
  • 🐛 Also missing some informations on the table (Forged, Vote Weight).
  • 🐛 The load more button shouldn't appear in cases like this: (should only appear if there are more information to load).
    image
Show resolved Hide resolved src/components/votingListViewV2/delegateRowV2.js Outdated

michaeltomasik added some commits May 13, 2019

@massao

massao approved these changes May 14, 2019

@michaeltomasik michaeltomasik merged commit 4df31f0 into development May 14, 2019

3 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

@michaeltomasik michaeltomasik deleted the 1961-new-design-delegate-table branch May 14, 2019

@slaweet slaweet added the ready label May 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.