Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement final ui of list of hw accounts page - closes #1934 #1987

Merged

Conversation

Projects
None yet
3 participants
@osvaldovega
Copy link
Contributor

commented May 7, 2019

What issue have I solved?

-- #1934

How have I implemented/fixed it?

This PR include the code/logic and page with the final design for select the accounts from the hardware wallet.

The selectAccount component get the information (device) from the previous page and with this information retrieve the accounts from the device, then after list the accounts that user is able to add/change account name (label), add another uninitialize account or select the account that want to use for login.

How has this been tested?

  1. For test this, the app needs to be running in electron not web version.
  2. Select the testnet and then do a click in the login with Hardware Wallet link.
  3. Then connect the Ledger Nano S or Trezor Model T device and unlock each device.
  4. Then from the devices list choose the available device and wait for load the accounts.
  5. Then with the accounts listed you can edit the name by putting the mouse over the account box and doing click on Edit button or you can do a click in the select account for continue,
  6. In the top there is the link for add another account.

Review checklist

massao and others added some commits May 2, 2019

Merge branch '1976-fix-ledger-not-being-recognize-after-hub-is-open' …
…of github.com:LiskHQ/lisk-hub into 1976-fix-ledger-not-being-recognize-after-hub-is-open

@osvaldovega osvaldovega self-assigned this May 7, 2019

osvaldovega added some commits May 3, 2019

@osvaldovega osvaldovega changed the base branch from development to 601-investigate-possible-improvements-to-build-time May 8, 2019

@osvaldovega osvaldovega changed the base branch from 601-investigate-possible-improvements-to-build-time to development May 8, 2019

@osvaldovega osvaldovega requested a review from michaeltomasik May 8, 2019

slaweet added some commits May 9, 2019

slaweet added some commits May 9, 2019

Merge branch '1934-implement-final-ui-of-list-of-HW-accounts-page' of…
… github.com:LiskHQ/lisk-hub into 1934-implement-final-ui-of-list-of-HW-accounts-page

@slaweet slaweet self-requested a review May 9, 2019

@slaweet

slaweet approved these changes May 9, 2019

Copy link
Member

left a comment

Thanks @osvaldovega 👍

@slaweet slaweet added the ready label May 9, 2019

@osvaldovega osvaldovega merged commit 96432cc into development May 9, 2019

3 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

@osvaldovega osvaldovega deleted the 1934-implement-final-ui-of-list-of-HW-accounts-page branch May 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.