Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove snyk - Closes #1967 #1990

Merged
merged 1 commit into from May 9, 2019

Conversation

Projects
None yet
2 participants
@slaweet
Copy link
Member

commented May 8, 2019

What issue have I solved?

#1967

How have I implemented/fixed it?

Removed snyk

How has this been tested?

Make sure jenkins passes.

Review checklist

@slaweet slaweet self-assigned this May 8, 2019

🔥 Remove snyk
For explanation see #1967

@slaweet slaweet force-pushed the 1967-remove-snyk branch from 692769f to 8684b8a May 8, 2019

@slaweet slaweet changed the base branch from development to 1.17.0 May 8, 2019

@slaweet slaweet changed the base branch from 1.17.0 to development May 8, 2019

@slaweet slaweet marked this pull request as ready for review May 8, 2019

@slaweet slaweet changed the base branch from development to 1.16.0 May 8, 2019

@slaweet slaweet changed the base branch from 1.16.0 to development May 8, 2019

@slaweet slaweet requested a review from osvaldovega May 9, 2019

@osvaldovega
Copy link
Contributor

left a comment

🧹PR approve

@osvaldovega osvaldovega added the ready label May 9, 2019

@slaweet slaweet merged commit cba1ef1 into development May 9, 2019

5 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls Coverage remained the same at 94.374%
Details
security/snyk - package.json (LiskHQ) No new issues
Details

@slaweet slaweet deleted the 1967-remove-snyk branch May 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.