Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup prefer-object-spread eslint rule - Closes #1966 #1991

Merged
merged 2 commits into from May 9, 2019

Conversation

Projects
None yet
2 participants
@slaweet
Copy link
Member

commented May 8, 2019

What issue have I solved?

#1966

How have I implemented/fixed it?

Edit .eslintrc and run npm run eslint -- --fix

How has this been tested?

npm run eslint

Review checklist

@slaweet slaweet self-assigned this May 8, 2019

@slaweet slaweet requested a review from osvaldovega May 8, 2019

@osvaldovega
Copy link
Contributor

left a comment

nice Vit, just 2 minor things some extra empty lines but all good

Show resolved Hide resolved src/actions/account.js
Show resolved Hide resolved src/components/hwWallet/ledgerLogin.js

@slaweet slaweet requested a review from osvaldovega May 8, 2019

@osvaldovega
Copy link
Contributor

left a comment

👍🏻perfect

@osvaldovega osvaldovega added the ready label May 8, 2019

@slaweet slaweet merged commit 417108a into development May 9, 2019

5 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls Coverage remained the same at 94.374%
Details
security/snyk - package.json (LiskHQ) No manifest changes detected

@slaweet slaweet deleted the 1966-eslint-prefer-object-spread-rule branch May 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.