Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Initialize Lisk Id button color - Closes #1996 #1998

Merged
merged 3 commits into from May 10, 2019

Conversation

Projects
None yet
4 participants
@slaweet
Copy link
Member

commented May 9, 2019

What issue have I solved?

#1996

How have I implemented/fixed it?

Changed the button to use the light theme.

There was a similar problem on the wallet page, so I fixed that one too.

How has this been tested?

Review checklist

slaweet added some commits May 9, 2019

@slaweet slaweet self-assigned this May 9, 2019

@slaweet slaweet requested a review from massao May 9, 2019

@massao
Copy link
Contributor

left a comment

The spacing of the footer element seems a bit weird, it seems to be getting some style from the send.css file for some reason.
image
Other than this, everything is working nice.

@slaweet slaweet requested a review from massao May 9, 2019

@slaweet

This comment has been minimized.

Copy link
Member Author

commented May 9, 2019

Good point, @massao. Fixed

@massao

massao approved these changes May 10, 2019

@massao massao requested a review from Efefefef May 10, 2019

@Efefefef
Copy link
Contributor

left a comment

👍

@Efefefef Efefefef added the ready label May 10, 2019

@yasharAyari yasharAyari merged commit ddfe3aa into 1.17.0 May 10, 2019

4 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls Coverage remained the same at 94.421%
Details

@yasharAyari yasharAyari deleted the 1996-fix-initialize-id-link branch May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.