Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable next button if second passphrase invalid - Closes #1957 #2012

Merged
merged 2 commits into from May 15, 2019

Conversation

Projects
None yet
3 participants
@slaweet
Copy link
Member

commented May 15, 2019

What issue have I solved?

#1957

How have I implemented/fixed it?

  • Fixed the isBtnDisabled condition
  • Wrote a unit test to test it
  • Refactored checkSecondPassphrase while I was figuring out how it works and what the fix should be.

How has this been tested?

Try to send with

'second passphrase account': {
passphrase: 'awkward service glimpse punch genre calm grow life bullet boil match like',
publicKey: 'fab9d261ea050b9e326d7e11587eccc343a20e64e29d8781b50fd06683cacc88',
serverPublicKey: 'fab9d261ea050b9e326d7e11587eccc343a20e64e29d8781b50fd06683cacc88',
secondPassphrase: 'forest around decrease farm vanish permit hotel clay senior matter endorse domain',
on localhost

Review checklist

@slaweet slaweet self-assigned this May 15, 2019

@slaweet slaweet requested a review from osvaldovega May 15, 2019

@osvaldovega
Copy link
Contributor

left a comment

so much better great Vit 👍🏻

@osvaldovega osvaldovega requested a review from Efefefef May 15, 2019

@Efefefef
Copy link
Contributor

left a comment

🐛 Empty 2ph should be invalid as well

@slaweet slaweet requested a review from Efefefef May 15, 2019

@Efefefef
Copy link
Contributor

left a comment

👍

@Efefefef Efefefef added the ready label May 15, 2019

@slaweet slaweet merged commit 48a9ea3 into development May 15, 2019

3 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

@slaweet slaweet deleted the 1957-prevent-send-with-invalid-2nd-passphrase branch May 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.